Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2024-01-22 Thread Di Zhang
2024 Q1 update: The new deprecation warnings has been in stable for multiple milestones: 118 (October 2023) to 121 (January 2024). The high usage appearance values are still getting used at similar rate. *NonStandardAppearanceValuesHighUsage*: (September 2023 -> January 2024 numbers) *

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-08-30 Thread TAMURA, Kent
LGTM3. On Thu, Aug 31, 2023 at 1:22 AM Daniel Bratell wrote: > LGTM2 > > /Daniel > On 2023-08-30 17:46, Alex Russell wrote: > > Thanks for being flexible here! > > LGTM1 to deprecate the first set of keywords (below < 0.001% use). Thanks > for coming back to us about the second set. > > Best,

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-08-30 Thread Daniel Bratell
LGTM2 /Daniel On 2023-08-30 17:46, Alex Russell wrote: Thanks for being flexible here! LGTM1 to deprecate the first set of keywords (below < 0.001% use). Thanks for coming back to us about the second set. Best, Alex On Tuesday, August 29, 2023 at 4:18:11 PM UTC-7 Di Zhang wrote:

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-08-30 Thread Alex Russell
Thanks for being flexible here! LGTM1 to deprecate the first set of keywords (below < 0.001% use). Thanks for coming back to us about the second set. Best, Alex On Tuesday, August 29, 2023 at 4:18:11 PM UTC-7 Di Zhang wrote: > Thanks to the advice above, I have done some improvements to the

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-08-29 Thread Di Zhang
Thanks to the advice above, I have done some improvements to the deprecation warning and how/when it will get shown to the user. After discussing with the DOM team, we have decided to split the feature into two parts. We will divide *NonStandardAppearanceValues* into two features:

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-08-09 Thread Daniel Bratell
That sounds good! Considering that the number in the use counter is already so low, it should be enough to show that a majority of the users only use the value that will not be removed and I'd be happy to see this ship. /Daniel On 2023-07-27 22:01, Di Zhang wrote: Hi, I had a talk with

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-27 Thread Di Zhang
Hi, I had a talk with Chris and Mason, who helped me better understand the steps for 2-3. I will aggregate more metrics data and share them in a google doc here soon. * What are the websites that uses these values most * What elements are they using the CSS property on, are there rendering

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-26 Thread Di Zhang
Hi Alex, It's great to have support on this deprecation. Since we feel a deprecation period of 117 to 120 is too short, I just removed the target milestone. It can be updated once we have better metric pulses. For suggestion 1, the wpt test appearance-cssom-001.html

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-26 Thread Alex Russell
Hey Di, Thanks for taking compat seriously. We chatted about this at API OWNERS this morning, and there'd broad support for the deprecation. There's also concern about the relatively short deprecation window, but maybe there are some ways we can build confidence? Some ideas that were

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-25 Thread Di Zhang
Thanks for the feedback. The counter does feel high, I will follow the Deprecation steps [1] and extend the milestones (likely DevTrial 117 and Shipping 3 milestones later at 120). [1]

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-25 Thread Yoav Weiss
Thanks!! So IIUC, any usage will result in rendering changes? If that's indeed the case, I think it makes sense to try and drive usage down before changing behavior.. On Tue, Jul 25, 2023 at 12:08 AM TAMURA, Kent wrote: > Valid appearance keywords have some side-effects even though they have no

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-24 Thread TAMURA, Kent
Valid appearance keywords have some side-effects even though they have no special painting. * Skip border painting * 'display' property value is changed to 'inline-block' or 'block'. So some properties such as 'width' 'height' are not ignored. Valid Invalid On Mon, Jul 24, 2023 at 5:00 PM

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-24 Thread Yoav Weiss
tkent@ - can you expand on the compat risk? It's not immediately obvious to me what these apps were doing that resulted in a rendering difference. On Mon, Jul 24, 2023, 03:45 TAMURA, Kent wrote: > Removing appearance keywords which have no painting code might have > compatibility issues. We

Re: [blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-23 Thread TAMURA, Kent
Removing appearance keywords which have no painting code might have compatibility issues. We removed the keyword "caret" in the past, and it caused issues like crbug.com/944023. The counter for this is https://chromestatus.com/metrics/feature/timeline/popularity/4416. The value is 0.005 - 0.02.

[blink-dev] Intent to Ship: Remove non-standard appearance keywords

2023-07-19 Thread Di Zhang
Contact emailsdizha...@chromium.org ExplainerNone Specificationhttps://drafts.csswg.org/css-ui-4/#appearance-switching Summary Since only standard appearance keywords should be supported, we are removing the appearance (and -webkit-appearance) keywords that shouldn't be supported anymore: *