FYI, this ended up being reverted soon and never reached stable. After 2+ years, I've relanded it in https://chromium-review.googlesource.com/c/chromium/src/+/5040561 and expect it will be in Chrome 121.
On Wed, Jun 30, 2021 at 3:55 PM Rick Byers <rby...@chromium.org> wrote: > LGTM3 - trivial, nearly just a bugfix > > On Wed, Jun 30, 2021 at 4:41 AM Daniel Bratell <bratel...@gmail.com> > wrote: > >> LGTM2 >> On 2021-06-30 01:40, TAMURA, Kent wrote: >> >> LGTM1. >> They should have interface objects, and the Gecko status is a good signal. >> >> On Wed, Jun 30, 2021 at 1:52 AM Philip Jägenstedt <foo...@chromium.org> >> wrote: >> >>> Contact emails foo...@chromium.org >>> >>> Specification https://wicg.github.io/speech-api/#tts-section >>> >>> Summary >>> >>> This is about the interface objects for SpeechSynthesis and >>> SpeechSynthesisVoice, not about the functionality itself which was already >>> supported. These interfaces should be exposed according to spec. Feature >>> detection using window.speechSynthesis was already possible, but this makes >>> feature detection using SpeechSynthesisVoice.prototype possible. Note that >>> SpeechSynthesisEvent, SpeechSynthesisErrorEvent and >>> SpeechSynthesisUtterance interface objects were already exposed. >>> >>> >>> Blink component Blink>Speech >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ESpeech> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> In general there is very little web compat risk by exposing a new >>> interface. However, since these interfaces have previously only been >>> exposed by Firefox, it's plausible some feature detection code involving >>> them has accidentally only worked on Firefox, and that Chromium will now go >>> down a new code path. This risk does not seem significant enough to do >>> anything preemptively. This is a minor and trivial change, but moving in >>> the direction of interoperability by matching Firefox and the spec. >>> >>> >>> Gecko: Shipped/Shipping ( >>> https://github.com/mozilla/gecko-dev/blob/44e39a47b27313029460bada366c67ebe6d7c57e/dom/webidl/SpeechSynthesis.webidl#L14) >>> Gecko's IDL does not have [LegacyNoInterfaceObject] here, and >>> SpeechSynthesis was shipped in Firefox 49: >>> https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesis#browser_compatibility >>> >>> WebKit: No signal ( >>> https://github.com/WebKit/WebKit/blob/56da0c5837801eb031c7506672cd7c40cbed4063/Source/WebCore/Modules/speech/SpeechSynthesis.idl#L27) >>> WebKit developers were not consulted, the FIXME is taken as evidence that >>> this change would be acceptable in WebKit as well. >>> >>> Web developers: No signals >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>> ? Yes: https://wpt.fyi/results/speech-api/idlharness.window.html >>> >>> Tracking bug >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1224942 >>> >>> MDN links >>> https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesis >>> https://developer.mozilla.org/en-US/docs/Web/API/SpeechSynthesisVoice >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/4818803819020288 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://www.chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdEZTQOoAr5L%3D1xpBzV7Z_L0M%2BzOrTyEdbT88uPtUPMnQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYdEZTQOoAr5L%3D1xpBzV7Z_L0M%2BzOrTyEdbT88uPtUPMnQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> TAMURA Kent >> Software Engineer, Google >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGmffB4z0XGUM2jr%2BArS6x63NViUkiW-tTT862yCJY6xg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGmffB4z0XGUM2jr%2BArS6x63NViUkiW-tTT862yCJY6xg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b2e84308-e934-f321-26bb-0c3e33491507%40gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b2e84308-e934-f321-26bb-0c3e33491507%40gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJ_uWHthnRdUmjO2rJGjQUEO%2BvVdFYTqiM9XBC_v0ixcDgTeJQ%40mail.gmail.com.
