Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-18 Thread Philip Jägenstedt
On Fri, Dec 15, 2023 at 9:03 PM Evan Stade wrote: > Thanks all! > > On Wed, Dec 13, 2023 at 5:10 AM Philip Jägenstedt > wrote: > >> Hi Evan, >> >> Thanks for looking into this, and for answering some of my questions >> off-list. To summarize, eviction is spec'd very loosely and a testdriver.js

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-15 Thread Evan Stade
Thanks all! On Wed, Dec 13, 2023 at 5:10 AM Philip Jägenstedt wrote: > Hi Evan, > > Thanks for looking into this, and for answering some of my questions > off-list. To summarize, eviction is spec'd very loosely and a testdriver.js > API could probably only be "evict everything" or "evict data

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-13 Thread Mike Taylor
LGTM3 On 12/13/23 11:04 AM, Rick Byers wrote: LGTM2 +1 to raising the bar on test automation, but only in the cases where there aren't unreasonable burdens and there is clear significant test coverage value (i.e., not this specific case). Thanks for the analysis Evan and Philip! On Wed,

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-13 Thread Rick Byers
LGTM2 +1 to raising the bar on test automation, but only in the cases where there aren't unreasonable burdens and there is clear significant test coverage value (i.e., not this specific case). Thanks for the analysis Evan and Philip! On Wed, Dec 13, 2023 at 8:10 AM Philip Jägenstedt wrote: >

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-13 Thread Philip Jägenstedt
Hi Evan, Thanks for looking into this, and for answering some of my questions off-list. To summarize, eviction is spec'd very loosely and a testdriver.js API could probably only be "evict everything" or "evict data in this bucket". Neither of those would test the interesting parts of how quota,

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-07 Thread Evan Stade
Hi Philip, After conferring with the team, we feel that there is an appropriate distribution of coverage provided by WPT and Chromium unit and browser tests. Leveraging testdriver for one-off hooks such as this would introduce substantial test-only code flows, diminishing the confidence that the

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-12-01 Thread Philip Jägenstedt
Thanks Evan for listing out the tests, they were more spread out than I thought. Great to see more of the tests being upstreamed too! I wonder if we can do even better and test eviction however? Have you looked into defining a WebDriver endpoint for triggering eviction? It could make sense in

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Evan Stade
Hi Philip, Here is a comprehensive list of web tests that verify storageBuckets behavior. We do feel the size of this list aligns well with the spec, which is fairly concise. As you can see, some are spread out in directories for the other storage APIs that storageBuckets brokers. That said, not

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Philip Jägenstedt
Hi Evan, Is https://wpt.fyi/results/storage/buckets?label=experimental=master the full set of tests? Given the size of the spec, does that cover the whole feature well? Best regards, Philip On Wed, Nov 29, 2023 at 5:58 PM Evan Stade wrote: > [reply-all this time] > > Hi Philip, > > thanks for

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Evan Stade
[reply-all this time] Hi Philip, thanks for pointing out those two oversights. I have fixed the checkboxes on the chromestatus entry. It is in fact tested by WPT and supported on all Blink platforms. On Wed, Nov 29, 2023 at 8:43 AM Philip Jägenstedt wrote: > Hi Evan, > > A few questions

Re: [blink-dev] Intent to Ship: Storage Buckets API

2023-11-29 Thread Philip Jägenstedt
Hi Evan, A few questions inline. On Tue, Nov 14, 2023 at 9:38 PM Evan Stade wrote: > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)? > > No > Which platform will this not be supported on? > Is this feature fully

[blink-dev] Intent to Ship: Storage Buckets API

2023-11-14 Thread Evan Stade
Contact emails est...@chromium.org, a...@chromium.org, ajayrahate...@chromium.org Explainer https://github.com/WICG/storage-buckets/blob/main/explainer.md Specification https://wicg.github.io/storage-buckets Summary Storage Buckets gives sites the ability to organize on-device data into