Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-05-14 Thread Yao Xiao
Hi Harley, This is a demo site for the cross-origin worklet: https://shared-storage-cross-origin-worklet-demo.glitch.me Yao On Tue, May 14, 2024 at 12:20 PM Harley Li wrote: > Hello - wondering whether this cross-origin feature reflected in the demo > website

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-05-14 Thread 'Harley Li' via blink-dev
Hello - wondering whether this cross-origin feature reflected in the demo website https://shared-storage-demo.web.app/ ? That is, not cross-origin-worklet-select-url-and-verify-data-origin.tentative.https.sub.html

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-29 Thread Yoav Weiss (@Shopify)
LGTM3 On Thu, Apr 25, 2024 at 5:57 PM Mike Taylor wrote: > LGTM2. > On 4/24/24 5:45 PM, Yao Xiao wrote: > > Hi Yao, > > I see that https://github.com/WICG/shared-storage/pull/152 is still open, >> can that be landed before we ship this? > > The PR landed just now. > > Also, can you point to the

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-25 Thread Mike Taylor
LGTM2. On 4/24/24 5:45 PM, Yao Xiao wrote: Hi Yao, I see that https://github.com/WICG/shared-storage/pull/152 is still open, can that be landed before we ship this? The PR landed just now. Also, can you point to the tests for this change? Yes.

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Yao Xiao
> > Hi Yao, I see that https://github.com/WICG/shared-storage/pull/152 is still open, > can that be landed before we ship this? The PR landed just now. Also, can you point to the tests for this change? Yes. cross-origin-worklet-select-url-and-verify-data-origin.tentative.https.sub.html

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Chris Harrelson
Thanks for the further explanation! It was very helpful. LGTM1, but please make sure to land that open PR before shipping. On Wed, Apr 24, 2024 at 10:48 AM Josh Karlin wrote: > Hey folks, I wanted to provide a bit more context on this change to help > clarify the intention and any associated

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Josh Karlin
Hey folks, I wanted to provide a bit more context on this change to help clarify the intention and any associated risks. Today, when a third-party script runs on a page and wants to write data to shared storage, or use their shared storage data (e.g., create an aggregate report) under its own

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Josh Karlin
On Wed, Apr 24, 2024 at 11:52 AM Alex Russell wrote: > Hey Josh, > > I agree that it might not be helpful to ping Gecko and WebKit on this, but > it would still be helpful to update the TAG on how this design is evolving. > Ack. I've updated the TAG thread

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Alex Russell
Hey Josh, I agree that it might not be helpful to ping Gecko and WebKit on this, but it would still be helpful to update the TAG on how this design is evolving. >From that perspective, I would expect the TAG to request that we improve consistency by making cross-origin workers (not just

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Chris Harrelson
On Fri, Apr 19, 2024 at 9:52 AM Yao Xiao wrote: > *Contact emails* > cam...@chromium.org > jkar...@chromium.org > yao...@chromium.org > rohitgu...@google.com > ashame...@google.com > > *Explainer* > https://github.com/WICG/shared-storage > > *Specification* >

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-24 Thread Philip Jägenstedt
Hi Yao, I see that https://github.com/WICG/shared-storage/pull/152 is still open, can that be landed before we ship this? Also, can you point to the tests for this change? Best regards, Philip On Fri, Apr 19, 2024 at 9:58 PM Josh Karlin wrote: > > > On Fri, Apr 19, 2024 at 1:59 PM Vladimir

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-19 Thread Josh Karlin
On Fri, Apr 19, 2024 at 1:59 PM Vladimir Levin wrote: > > > On Fri, Apr 19, 2024 at 12:52 PM Yao Xiao wrote: > >> *Contact emails* >> cam...@chromium.org >> jkar...@chromium.org >> yao...@chromium.org >> rohitgu...@google.com >> ashame...@google.com >> >> *Explainer* >>

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-19 Thread Josh Karlin
On Fri, Apr 19, 2024 at 3:49 PM Mike Taylor wrote: > On 4/19/24 12:52 PM, Yao Xiao wrote: > > *Contact emails* > cam...@chromium.org > jkar...@chromium.org > yao...@chromium.org > rohitgu...@google.com > ashame...@google.com > > *Explainer* > https://github.com/WICG/shared-storage > > Would it

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-19 Thread Mike Taylor
On 4/19/24 12:52 PM, Yao Xiao wrote: *Contact emails* cam...@chromium.org jkar...@chromium.org yao...@chromium.org rohitgu...@google.com ashame...@google.com *Explainer* https://github.com/WICG/shared-storage Would it be possible to write a paragraph on this specific change, i.e., what are

Re: [blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-19 Thread Vladimir Levin
On Fri, Apr 19, 2024 at 12:52 PM Yao Xiao wrote: > *Contact emails* > cam...@chromium.org > jkar...@chromium.org > yao...@chromium.org > rohitgu...@google.com > ashame...@google.com > > *Explainer* > https://github.com/WICG/shared-storage > > *Specification* >

[blink-dev] Intent to Ship: Support Cross-Origin Shared Storage Worklets

2024-04-19 Thread Yao Xiao
*Contact emails* cam...@chromium.org jkar...@chromium.org yao...@chromium.org rohitgu...@google.com ashame...@google.com *Explainer* https://github.com/WICG/shared-storage *Specification* https://wicg.github.io/shared-storage/ *Additional anticipated specification changes*