Re: LRe: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-07-16 Thread 'Yaroslav Shalivskyy' via blink-dev
Hey William! I confirm that I can see light scrollbars in the PDF viewer in Chrome Canary. However, I think the bug is not related to the used color scheme root scrollbars feature. I see that the scrollbar on the right side in PDF viewer is not the global root scroller (see more details README.m

Re: LRe: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-07-16 Thread William Smith
Sorry if this isn't the correct place to ask but I just noticed in Chrome Canary, the scrollbar is still light when viewing PDF's. Does anyone know if this is working as intended or if it's a bug? On Tuesday, April 30, 2024 at 10:21:48 PM UTC-4 William Smith wrote: > Hey another nice bonus with

Re: LRe: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-04-30 Thread William Smith
Hey another nice bonus with this excellent change is: the YouTube desktop website no longer has to use their dreadful custom scrollbar (see attached screenshot) which has quite a few issues and downsides compared to the standard Chrome scrollbar. Finally they can do away with that and just use

LRe: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Domenic Denicola
LGTM3 On Wednesday, March 27, 2024 at 4:45:08 AM UTC+9 Mike Taylor wrote: > LGTM2 > On 3/26/24 1:25 PM, Yoav Weiss (@Shopify) wrote: > > LGTM1 once the fix > to > the above issue lands. > > On Monday, March 18, 2024 at 7:56:52 

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Mike Taylor
LGTM2 On 3/26/24 1:25 PM, Yoav Weiss (@Shopify) wrote: LGTM1 once the fix to the above issue lands. On Monday, March 18, 2024 at 7:56:52 PM UTC+1 yshal...@microsoft.com wrote: Yes, I believe the bug [1] is a blocker.

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM1 once the fix to the above issue lands. On Monday, March 18, 2024 at 7:56:52 PM UTC+1 yshal...@microsoft.com wrote: > Yes, I believe the bug [1] is a blocker. > > [1] https://issues.chromium.org/issues/328102503. > > On Mo

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-18 Thread 'Yaroslav Shalivskyy' via blink-dev
Yes, I believe the bug [1] is a blocker. [1] https://issues.chromium.org/issues/328102503. On Monday, March 18, 2024 at 1:51:43 AM UTC-7 yoav...@chromium.org wrote: > Great to see a positive position from Mozilla on this. > > Is the above mentioned bug a blocker here? > > On Friday, March 8, 202

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-18 Thread Yoav Weiss (@Shopify)
Great to see a positive position from Mozilla on this. Is the above mentioned bug a blocker here? On Friday, March 8, 2024 at 12:52:58 AM UTC+1 yshal...@microsoft.com wrote: > Thanks for taking a look and your feedback! Please let me know if you have > any other questions or concerns. > On Thur

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-07 Thread 'Yaroslav Shalivskyy' via blink-dev
Thanks for taking a look and your feedback! Please let me know if you have any other questions or concerns. On Thursday, March 7, 2024 at 3:23:02 PM UTC-8 William Smith wrote: > Thank you! And just to be clear, I personally don't see it as a problem at > all, I was only curious. I actually think

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-07 Thread William Smith
Thank you! And just to be clear, I personally don't see it as a problem at all, I was only curious. I actually think this should have shipped along with dark mode back in 2019, but better late than never. On Thursday, March 7, 2024 at 5:22:14 PM UTC-5 Yaroslav Shalivskyy wrote: > Hello William

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-06 Thread William Smith
Apologies if this isn't the correct place to ask this but I have this working in Chrome Canary and as fantastic as it is, they behavior on some websites has me confused: on https://en.wikipedia.org/wiki/Main_Page and amazon.com the scrollbar is dark, but neither of those webpages have a dark mo

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-05 Thread 'Yaroslav Shalivskyy' via blink-dev
Mike and Daniel, thank you for the suggestions! I requested browser vendor positions as well as reviews for chromestatus entry. Mozilla: [css-color-adjust-1] Root non-overlay scrollbars used color scheme · Issue #995 · mozilla/standards-positions (github.com)

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-04 Thread Mike Taylor
Thanks for the summary of the experiment results on Edge - sounds positive. If this is purely a browser UI change, then we don't really need the blink-dev process at all. However, if we're relying on concepts defined in a CSSWG draft, and devs can change the outcome w/ some CSS (or maybe here,

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-02 Thread Daniel Bratell
Mike didn't refer to the TAG review or browser signals, but the review steps in chromestatus. The intent should request, privacy, security, enterprise, and the other steps there. I agree that this lives in the borderland between user agent UI and a web visible change so some shortcuts might be

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-01 Thread 'Yaroslav Shalivskyy' via blink-dev
Hello Mike, Thank you for taking a look! I am seeking consensus on how to approach the feature from a standardization perspective. I think the feature can be considered a browser UI change, which is why I haven't requested a TAG review or signals from other engines. However, I am open to doi

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-01 Thread Mike Taylor
Hi there, Would you mind requesting reviews for the various review gates in your chromestatus entry? On 2/29/24 4:12 PM, 'Yaroslav Shalivskyy' via blink-dev wrote: Contact emails gerch...@microsoft.com , yshalivs...@microsoft.com

[blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-02-29 Thread 'Yaroslav Shalivskyy' via blink-dev
Contact emails gerch...@microsoft.com, yshalivs...@microsoft.com Explainer None Specification https://www.w3.org/TR/css-color-adjust-1 Summary Makes the browser use the user's preferred color scheme to render the viewport scroll