Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-22 Thread Traian Captan
Thanks Mike! Once the spec gets sorted out I can add the additional WPT tests. On Wed, Aug 21, 2024 at 8:44 AM Mike Taylor wrote: > LGTM2 - it would be great to add additional tests as mentioned. > On 8/21/24 5:43 PM, Alex Russell wrote: > > LGTM1; thanks for the detailed responses to Domenic.

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-22 Thread Traian Captan
Thanks Alex! On Wed, Aug 21, 2024 at 8:43 AM Alex Russell wrote: > LGTM1; thanks for the detailed responses to Domenic. > > On Sunday, August 18, 2024 at 10:30:50 PM UTC-7 Traian Captan wrote: > >> This relates to the interoperability issues discussed below. You say >>> "This change increases i

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-21 Thread Domenic Denicola
(Unnecessary) LGTM4. Thanks to all your detailed answers, I think the compat and interop risk is low, and am excited to see this ship. If you or your team has time to follow up on https://github.com/whatwg/html/issues/10569 to finish the spec and tests story, that would be a great help. On Thu

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-21 Thread Daniel Bratell
LGTM3 /Daniel On 2024-08-21 17:44, Mike Taylor wrote: LGTM2 - it would be great to add additional tests as mentioned. On 8/21/24 5:43 PM, Alex Russell wrote: LGTM1; thanks for the detailed responses to Domenic. On Sunday, August 18, 2024 at 10:30:50 PM UTC-7 Traian Captan wrote: Th

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-21 Thread Mike Taylor
LGTM2 - it would be great to add additional tests as mentioned. On 8/21/24 5:43 PM, Alex Russell wrote: LGTM1; thanks for the detailed responses to Domenic. On Sunday, August 18, 2024 at 10:30:50 PM UTC-7 Traian Captan wrote: This relates to the interoperability issues discussed below.

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-21 Thread Alex Russell
LGTM1; thanks for the detailed responses to Domenic. On Sunday, August 18, 2024 at 10:30:50 PM UTC-7 Traian Captan wrote: > This relates to the interoperability issues discussed below. You say "This >> change increases interop with Safari and Firefox which already provide a >> reasonable fallba

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-18 Thread Traian Captan
> > This relates to the interoperability issues discussed below. You say "This > change increases interop with Safari and Firefox which already provide a > reasonable fallback style for elements with `appearance: none`," > but don't give detail on whether our "reasonable fallback style" is the > s

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-15 Thread Domenic Denicola
On Thu, Aug 15, 2024 at 6:07 PM Traian Captan wrote: > > > On Mon, Aug 12, 2024 at 10:51 PM Domenic Denicola > wrote: > >> SpecificationNone >>> >> >> My understanding is that appearance: none has a specification, probably >> around https://drafts.csswg.org/css-ui/#appearance-switching . Can you

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-15 Thread Traian Captan
On Mon, Aug 12, 2024 at 10:51 PM Domenic Denicola wrote: > SpecificationNone >> > > My understanding is that appearance: none has a specification, probably > around https://drafts.csswg.org/css-ui/#appearance-switching . Can you > ensure this field is filled out, and more importantly, that the >

Re: [blink-dev] Intent to Ship: meter element fallback styles

2024-08-12 Thread Domenic Denicola
On Tue, Aug 13, 2024 at 6:05 AM Traian Captan wrote: > Contact emailstcap...@chromium.org > > ExplainerNone > > SpecificationNone > My understanding is that appearance: none has a specification, probably around https://drafts.csswg.org/css-ui/#appearance-switching . Can you ensure this field is

[blink-dev] Intent to Ship: meter element fallback styles

2024-08-12 Thread Traian Captan
Contact emailstcap...@chromium.org ExplainerNone SpecificationNone Summary With this change elements with `appearance: none` will have a reasonable fallback style that matches Safari and Firefox instead of just disappearing from the page. As well developers will be able to custom style the el