Re: [blink-dev] Merging a UseCounter addition

2023-10-05 Thread 'Daniel Cheng' via blink-dev
I think what you've done is fine; that being said, I probably would have just cherry-picked the specific use counter the diff uses, but I don't think it really makes a difference either way. Daniel On Thu, 5 Oct 2023 at 13:25, Donn Denman wrote: > Can someone review a merge of new UseCounters i

[blink-dev] Merging a UseCounter addition

2023-10-05 Thread Donn Denman
Can someone review a merge of new UseCounters in https://crrev.com/c/4915881 ? I'm merging a CL that adds UseCounters, but my counters are not the next sequential values due to other additions that are not being merged. I'm thinking it's OK to add those values to third_party/blink/public/mojom/use