Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-06-04 Thread Yoav Weiss (@Shopify)
Thanks for the extra support :) On Tue, Jun 4, 2024, 09:30 Daniel Bratell wrote: > Doh, make that a bonus LGTM4. Sorry for the confusion. > > /Daniel > On 2024-06-04 09:29, Daniel Bratell wrote: > > LGTM3 > > /Daniel > On 2024-05-30 19:41, Vladimir Levin wrote: > > LGTM2 > > On Wed, May 29,

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-06-04 Thread Daniel Bratell
Doh, make that a bonus LGTM4. Sorry for the confusion. /Daniel On 2024-06-04 09:29, Daniel Bratell wrote: LGTM3 /Daniel On 2024-05-30 19:41, Vladimir Levin wrote: LGTM2 On Wed, May 29, 2024 at 11:41 AM Mike Taylor wrote: LGTM1 On 5/24/24 3:13 PM, Yoav Weiss (@Shopify) wrote:

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-06-04 Thread Daniel Bratell
LGTM3 /Daniel On 2024-05-30 19:41, Vladimir Levin wrote: LGTM2 On Wed, May 29, 2024 at 11:41 AM Mike Taylor wrote: LGTM1 On 5/24/24 3:13 PM, Yoav Weiss (@Shopify) wrote: On Fri, May 24, 2024 at 7:12 PM Panos Astithas wrote: On Wed, May 22, 2024 at 2:16 AM

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-30 Thread Chris Harrelson
LGTM3 On Thu, May 30, 2024 at 10:41 AM Vladimir Levin wrote: > LGTM2 > > On Wed, May 29, 2024 at 11:41 AM Mike Taylor > wrote: > >> LGTM1 >> On 5/24/24 3:13 PM, Yoav Weiss (@Shopify) wrote: >> >> >> >> On Fri, May 24, 2024 at 7:12 PM Panos Astithas >> wrote: >> >>> >>> >>> On Wed, May 22,

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-30 Thread Vladimir Levin
LGTM2 On Wed, May 29, 2024 at 11:41 AM Mike Taylor wrote: > LGTM1 > On 5/24/24 3:13 PM, Yoav Weiss (@Shopify) wrote: > > > > On Fri, May 24, 2024 at 7:12 PM Panos Astithas > wrote: > >> >> >> On Wed, May 22, 2024 at 2:16 AM Yoav Weiss (@Shopify) < >> yoavwe...@chromium.org> wrote: >> >>> >>>

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-29 Thread Mike Taylor
LGTM1 On 5/24/24 3:13 PM, Yoav Weiss (@Shopify) wrote: On Fri, May 24, 2024 at 7:12 PM Panos Astithas wrote: On Wed, May 22, 2024 at 2:16 AM Yoav Weiss (@Shopify) wrote: On Wed, May 22, 2024 at 10:29 AM Yoav Weiss (@Shopify) wrote: On Tuesday,

[blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-24 Thread Yoav Weiss (@Shopify)
On Fri, May 24, 2024 at 7:12 PM Panos Astithas wrote: > > > On Wed, May 22, 2024 at 2:16 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Wed, May 22, 2024 at 10:29 AM Yoav Weiss (@Shopify) < >> yoavwe...@chromium.org> wrote: >> >>> >>> >>> On Tuesday, May 21, 2024 at

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-24 Thread Yoav Weiss (@Shopify)
On Fri, May 24, 2024 at 5:57 PM Alex Russell wrote: > I'm also not sure why we would wait. > Waiting a few more days won't change much, so it's perfectly fine. > That said, if we're expanding SRI, it would be great to see media > resources included. Won't block this intent on it, but for

[blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-24 Thread 'Panos Astithas' via blink-dev
On Wed, May 22, 2024 at 2:16 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Wed, May 22, 2024 at 10:29 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Tuesday, May 21, 2024 at 1:04:44 PM UTC+2 Yoav Weiss wrote: >> >> Contact

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-24 Thread Alex Russell
I'm also not sure why we would wait. That said, if we're expanding SRI, it would be great to see media resources included. Won't block this intent on it, but for architectural consistency want to flag that we aren't "done". On Wed, May 22, 2024, 6:39 PM Mike Taylor wrote: > I'm inclined to

Re: [blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-22 Thread Mike Taylor
I'm inclined to LGTM this now - but don't see a lot of harm waiting for 1 additional week (per Mozilla's request in the not-public minutes). Happy to do so before, so long as the HTML PR lands. On 5/22/24 5:15 AM, Yoav Weiss (@Shopify) wrote: On Wed, May 22, 2024 at 10:29 AM Yoav Weiss

[blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-22 Thread 'Ilya Grigorik' via blink-dev
Kudos, Yoav! Excited to see rapid progress on this: Webkit PR is merged \o/, hoping to see this in M127, and fingers crossed for fast follow with FF. As background context and motivation, this is an important building block for enabling PCIv4 compliance for ecomm sites. v4 requires that the

[blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-22 Thread Yoav Weiss (@Shopify)
On Wed, May 22, 2024 at 10:29 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Tuesday, May 21, 2024 at 1:04:44 PM UTC+2 Yoav Weiss wrote: > > Contact emailsyoavwe...@chromium.org > > Explainerhttps://github.com/guybedford/import-maps-extensions#integrity > >

[blink-dev] Re: Intent to Ship: Importmap integrity

2024-05-22 Thread Yoav Weiss (@Shopify)
On Tuesday, May 21, 2024 at 1:04:44 PM UTC+2 Yoav Weiss wrote: Contact emailsyoavwe...@chromium.org Explainerhttps://github.com/guybedford/import-maps-extensions#integrity Specificationhttps://github.com/whatwg/html/pull/10269 The PR is ready to land, but we're holding off on that for 2