Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On 3/25/25 1:39 PM, Yoav Weiss (@Shopify) wrote: On Tue, Mar 25, 2025 at 10:37 AM Vladimir Levin wrote: I'm not convinced this is a huge footgun. Yes, it's a convenience value that allows auto matching in MPA where there is no other way to automatically match without changes to th

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

Let me try and explain the breaking case again. I'll describe it in terms of a React component for brevity, but the same issue exists with regular DOM. Here's a basic list of items, with a button that randomises the order of the list. This is one of the main use-cases given for this feature. expo

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

Note that we've agreed to separate this intent into two separate intents for `match-element` (https://groups.google.com/a/chromium.org/g/blink-dev/c/o3JcMI6dGdY/m/bg3z-WX3BwAJ) and `auto` (https://groups.google.com/a/chromium.org/g/blink-dev/c/KCizytrJUMA/m/dqg_mEX4BwAJ). This intent is depr

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

> > > > *Until this feature (correct me if I'm wrong), adding a unique ID to an > element was safe. With this feature, that's no longer the case.* > > > This seems like a worthwhile question to bring back to the TAG and/or the > CSSWG. Looking at the TAG review, it doesn't seem like it was discusse

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

It's unconvincing re: deprecation risk that Apple has decided in the short run that they don't want to unship to deliver a better feature (without the benefits of developer-oriented quality protections that our process provides). We should always be trying to answer the question "*does this sol

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On Tue, Mar 25, 2025 at 1:52 PM Mike Taylor wrote: > On 3/25/25 1:39 PM, Yoav Weiss (@Shopify) wrote: > > On Tue, Mar 25, 2025 at 10:37 AM Vladimir Levin > wrote: > >> I'm not convinced this is a huge footgun. Yes, it's a convenience value >> that allows auto matching in MPA where there is no ot

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On Tue, Mar 25, 2025 at 10:37 AM Vladimir Levin wrote: > I'm not convinced this is a huge footgun. Yes, it's a convenience value > that allows auto matching in MPA where there is no other way to > automatically match without changes to the dom (for a custom attribute). > Doing these modification

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On Tuesday, March 25, 2025 at 5:12:17 AM UTC-4 Jake Archibald wrote: Let me try and explain the breaking case again. I'll describe it in terms of a React component for brevity, but the same issue exists with regular DOM. Here's a basic list of items, with a button that randomises the order of

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

I'm not convinced this is a huge footgun. Yes, it's a convenience value that allows auto matching in MPA where there is no other way to automatically match without changes to the dom (for a custom attribute). Doing these modification is not far from just giving unique names to view-transition-name,

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

I've summarised the issues with this proposal in the TAG thread . On Tue, 25 Mar 2025 at 10:44, Noam Rosenthal wrote: > >> >> *Until this feature (correct me if I'm wrong), adding a unique ID to an >> element was safe

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On Tue, 25 Mar 2025 at 10:31, Yoav Weiss wrote: > On Tuesday, March 25, 2025 at 5:12:17 AM UTC-4 Jake Archibald wrote: > > This issue wouldn't happen if any of the following was done instead: > > >- Each element was assigned a unique view-transition-name ident >- view-transition-name: mat

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

The example I gave isn't a versioning issue, it results from overloading the id attribute. The example I gave wouldn't be broken if view-transition-name was given an ident. And it's less likely to happen if the name was pulled from a dedicated attribute eg data-vtn via attr(), since that wouldn't

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

(feature author hat) I'd like to highlight that view-transition-name: auto does have a need in MPA, where match-element cannot match anything across different documents. I agree that the versioning problem that Jake mentioned exists in that case, but it seems similar to any other versioning proble

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

On Mon, Mar 24, 2025, 6:20 PM Alex Russell wrote: > It seems like Jake's concern is well founded. Was this discussed at CSS > WG? Do we understand why this problematic design is going forward in other > engines? It was discussed multiple times with the CSSWG. They seem to believe that the ID-ba

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

It seems like Jake's concern is well founded. Was this discussed at CSS WG? Do we understand why this problematic design is going forward in other engines? Best, Alex On Monday, March 24, 2025 at 6:30:42 AM UTC-7 Mike Taylor wrote: > LGTM2 > On 3/24/25 4:22 AM, Domenic Denicola wrote: > > Tha

Re: [blink-dev] Re: Intent to Ship: Auto-generated view transition names

LGTM2 On 3/24/25 4:22 AM, Domenic Denicola wrote: Thanks for the quick responses! LGTM1. On Mon, Mar 24, 2025 at 4:37 PM Noam Rosenthal wrote: On Mon, Mar 24, 2025 at 5:53 AM Domenic Denicola wrote: Generally in good shape, but I have questions about potential op