Re: [boinc_dev] could the git comment be more descriptive or better empty ?
On 05/29/2013 01:08 AM, Charlie Fenton wrote: I agree with Jord that 'quick updates', or 'quick fixes' is not helpful, but I also don't want to see empty commit messages. I feel that _every_ commit should have a commit message briefly describing what was changed and why. Yeah - I was just grumbling about a commit with the only message Include cmath instead of math.h various places nothing else - and of course gitk shows for a dozen of files such a change. Every ?!%%$$ user can see the diff using gitk - so important IMO is just a short notice why cmath.h rules over math.h -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
Re: [boinc_dev] could the git comment be more descriptive or better empty ?
Hi Toralf, Yeah - I was just grumbling about a commit with the only message Include cmath instead of math.h various places nothing else - and of course gitk shows for a dozen of files such a change. Every ?!%%$$ user can see the diff using gitk - so important IMO is just a short notice why cmath.h rules over math.h http://stackoverflow.com/questions/8734230/math-interface-vs-cmath-in-c Did you run in to any problems because of that change? A discussion about cmath being better or worse than math.h for BOINC I would rather want to see here than with the commit. Cheers, Steffen ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
[boinc_dev] could the git comment be more descriptive or better empty ?
It would be sometimes helpful for 3rd party testers/reviewers/people_which_are_just_interested if the git comments would be more descriptive or completely empty to not waste space, especially comments shouldn't tell what was changed but why a change was made, or ? -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3 ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
Re: [boinc_dev] could the git comment be more descriptive or better empty ?
Please give examples of non-descriptive comments. -- David On 28-May-2013 1:56 PM, Toralf Förster wrote: It would be sometimes helpful for 3rd party testers/reviewers/people_which_are_just_interested if the git comments would be more descriptive or completely empty to not waste space, especially comments shouldn't tell what was changed but why a change was made, or ? ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
Re: [boinc_dev] could the git comment be more descriptive or better empty ?
I'd rather that there'd be a more uniform use the prefixes. That everyone use the same prefix, so that those of us keeping change logs can see a bit easier what goes where. Now there's a couple of entries that say client, but are android. Or some entries that have no prefix whatsoever, and only by opening the whole commit and checking what files were they changed in, can we determine if it was a change for the change log or not. Like these: android API client condor db-purge MGR scheduler server web Now one person does Client, the other client, the third nothing. Or one person uses mgr, the other MGR, then a third says Manager, etc. It would also be nice if all sentences ended with a full stop, but perhaps that's just wishful thinking. :-) As for 'non-descriptive comments', we all hate the 'quick updates', or 'quick fixes'. I just take it that sometimes those cannot be helped. On Tue, May 28, 2013 at 10:59 PM, David Anderson da...@ssl.berkeley.edu wrote: Please give examples of non-descriptive comments. -- David On 28-May-2013 1:56 PM, Toralf Förster wrote: It would be sometimes helpful for 3rd party testers/reviewers/people_which_are_just_interested if the git comments would be more descriptive or completely empty to not waste space, especially comments shouldn't tell what was changed but why a change was made, or ? ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address. -- -- Jord van der Elst. ___ boinc_dev mailing list boinc_dev@ssl.berkeley.edu http://lists.ssl.berkeley.edu/mailman/listinfo/boinc_dev To unsubscribe, visit the above URL and (near bottom of page) enter your email address.
