Re: [boinc_dev] keyword.cpp, .h build breaks on Mac

2017-07-30 Thread Vitalii Koshura
Hello all, In a perfect world such kind of changes are made in a separate branch. This helps to avoid broken builds. Also we have a pull request https://github.com/BOINC/boinc/pull/1821 which also can notify developer about broken build. @David, could you please take a look at this pull request

Re: [boinc_dev] keyword.cpp, .h build breaks on Mac

2017-07-30 Thread Richard Haselgrove
I pointed out the Travis build error report almost 12 hours ago, on a mailing list which I know David reads. I don't have your expertise in tracking down the cause of the error (and I don't think I have access to the Travis error messages), but in a case like this, shouldn't the developer

[boinc_dev] keyword.cpp, .h build breaks on Mac

2017-07-30 Thread Charlie Fenton
The latest commit for keyword.cpp and keyword.h broke the builds on the Mac. [1] Adding #include after #include "parse.h" fixes the compiler errors for keyword.h, but I don't know if this needs to be guarded by #ifdef __APPLE__ or if it is OK (and perhaps even necessary) to include it for all