Re: Review Request: BOOKKEEPER-193: Ledger is garbage collected by mistake.

2012-03-28 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4481/#review6481 --- It looks very good, Sijie. I have just a few points.

[jira] [Commented] (BOOKKEEPER-193) Ledger is garbage collected by mistake.

2012-03-28 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240284#comment-13240284 ] jirapos...@reviews.apache.org commented on BOOKKEEPER-193: --

[jira] [Commented] (BOOKKEEPER-181) Scale hedwig

2012-03-28 Thread Flavio Junqueira (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240287#comment-13240287 ] Flavio Junqueira commented on BOOKKEEPER-181: - bq. hmm, hbase did provide

Re: Jenkins failures

2012-03-28 Thread Flavio Junqueira
Do you know why it fails when jenkins run and not when we run it? Is it a an issue with the Apache machine running it? In general, I just think it would be good to have it more reliably running it, otherwise it defeats the purpose of having jenkins running it and sending these reports. -Flavio

Re: Review Request: BOOKKEEPER-193: Ledger is garbage collected by mistake.

2012-03-28 Thread Sijie Guo
On 2012-03-28 08:10:21, fpj wrote: bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java, line 124 https://reviews.apache.org/r/4481/diff/1/?file=95778#file95778line124 Can we perhaps use another latch here instead of time? Relying on time doesn't

[jira] [Commented] (BOOKKEEPER-193) Ledger is garbage collected by mistake.

2012-03-28 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240313#comment-13240313 ] jirapos...@reviews.apache.org commented on BOOKKEEPER-193: --

[jira] [Updated] (BOOKKEEPER-194) Get correct latency for addEntry operations for JMX.

2012-03-28 Thread Sijie Guo (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-194: - Attachment: BK-194.diff attach a patch to compute addEntry latency in writecallback.

Jenkins build is back to stable : bookkeeper-trunk #429

2012-03-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/bookkeeper-trunk/429/

[jira] [Created] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a specialNode

2012-03-28 Thread Ivan Kelly (Created) (JIRA)
HierarchicalLedgerManager doesn't consider idgen as a specialNode --- Key: BOOKKEEPER-195 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195 Project: Bookkeeper Issue

[jira] [Updated] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a specialNode

2012-03-28 Thread Ivan Kelly (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-195: -- Attachment: BOOKKEEPER-195.diff Fix is simple HierarchicalLedgerManager

[jira] [Updated] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a specialNode

2012-03-28 Thread Ivan Kelly (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-195: -- Attachment: BOOKKEEPER-195.diff HierarchicalLedgerManager doesn't consider idgen as a

[jira] [Commented] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a specialNode

2012-03-28 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240793#comment-13240793 ] Hudson commented on BOOKKEEPER-195: --- Integrated in bookkeeper-trunk #430 (See