---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17895/#review41130
---
[
https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978048#comment-13978048
]
Ivan Kelly commented on BOOKKEEPER-582:
---
Made a few comments on reviewboard. In
Hi folks,
I'm going to have shoulder surgery tomorrow, so I'll be down an arm
for 4 weeks. This means less typing, less coding, so it's a good
opportunity to get me to review patches. It would be a good
opportunity to get the last patches for 4.3.0 in.
Regards
Ivan
Aiming for tomorrow sounds like a stretch, but I'll carve out some time to
look at patches. There are 8 patch avaialables.
-Flavio
-Original Message-
From: Ivan Kelly [mailto:iv...@apache.org]
Sent: 23 April 2014 11:41
To: bookkeeper-dev@zookeeper.apache.org
Subject: Reviews over
Out of these around 5 issues are marked for 4.2.3 release. Most of them are
dependent to each other and I feel we can try push one by one.
So will get the QA report for the dependent ones.
In coming days, I'll also try to get sometime to see 4.3.0 issues and go over
the ones I've been
The 4.2.3 issues all have their dependencies marked in
sequence. Currently BOOKKEEPER-742 is waiting to be given a final +1
before committing.
-Ivan
On Wed, Apr 23, 2014 at 01:18:40PM +, Rakesh R wrote:
Out of these around 5 issues are marked for 4.2.3 release. Most of them are
[
https://issues.apache.org/jira/browse/BOOKKEEPER-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978245#comment-13978245
]
Rakesh R commented on BOOKKEEPER-742:
-
Thanks Ivan. +1 latest patch looks nice.
On April 23, 2014, 10:22 a.m., Ivan Kelly wrote:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerChecker.java,
line 131
https://reviews.apache.org/r/17895/diff/2/?file=563019#file563019line131
This change seems unrelated. I don't mind it going in, but could you
