Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

2014-04-25 Thread Ivan Kelly
On April 24, 2014, 12:19 p.m., Ivan Kelly wrote: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 81 https://reviews.apache.org/r/17895/diff/2/?file=563033#file563033line81 ledgerId and entryId should be optional in all requests. It may be the case, that how we

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

2014-04-25 Thread Sijie Guo
On April 24, 2014, 12:19 p.m., Ivan Kelly wrote: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 81 https://reviews.apache.org/r/17895/diff/2/?file=563033#file563033line81 ledgerId and entryId should be optional in all requests. It may be the case, that how we

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

2014-04-25 Thread Sijie Guo
On April 23, 2014, 10:22 a.m., Ivan Kelly wrote: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 104 https://reviews.apache.org/r/17895/diff/2/?file=563033#file563033line104 You're sending StatusCode twice, every time. Firstly, shouldn't be an enum as stated

[jira] [Updated] (BOOKKEEPER-560) Create readme for hedwig-client-jms

2014-04-25 Thread Mridul Muralidharan (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Muralidharan updated BOOKKEEPER-560: --- Assignee: (was: Mridul Muralidharan) Create readme for

[jira] [Updated] (BOOKKEEPER-648) BasicJMSTest failed

2014-04-25 Thread Mridul Muralidharan (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Muralidharan updated BOOKKEEPER-648: --- Assignee: (was: Mridul Muralidharan) BasicJMSTest failed