Re: Synchronous calls in asynchronous callbacks for bookie auto recovery

2014-11-14 Thread Ivan Kelly
I wasn't aware of this. No objections to changing it. In fact, I actively encourage it. -Ivan On 14 November 2014 01:56, Sijie Guo guosi...@gmail.com wrote: Hi guys: I am revisiting the auto-recovery code. There were tons of synchronous calls in asynchronous callbacks (zookeeper/bookkeeper

Re: Synchronous calls in asynchronous callbacks for bookie auto recovery

2014-11-14 Thread Flavio Junqueira
Yeah, I had noticed the synchronous ZK calls. +1 for making them asynchronous. -Flavio On Friday, November 14, 2014 10:48 AM, Ivan Kelly i...@ivankelly.net wrote: I wasn't aware of this. No objections to changing it. In fact, I actively encourage it. -Ivan On 14 November 2014

Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-14 Thread fpj
On Nov. 12, 2014, 4:33 p.m., fpj wrote: I quite like the changes here, they make sense to me. I just have one clarification question and a small suggestion below. I'm happy with the changes. Any other comment here or should I get this in? On Nov. 12, 2014, 4:33 p.m., fpj wrote:

Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-14 Thread Sijie Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27529/#review61600 --- I will review this over this weekend. - Sijie Guo On Nov. 13,