Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-14 Thread fpj
On Nov. 12, 2014, 4:33 p.m., fpj wrote: I quite like the changes here, they make sense to me. I just have one clarification question and a small suggestion below. I'm happy with the changes. Any other comment here or should I get this in? On Nov. 12, 2014, 4:33 p.m., fpj wrote:

Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-14 Thread Sijie Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27529/#review61600 --- I will review this over this weekend. - Sijie Guo On Nov. 13,

Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-13 Thread Ivan Kelly
On Nov. 12, 2014, 4:33 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java, line 888 https://reviews.apache.org/r/27529/diff/1/?file=747433#file747433line888 I'm a bit confused by the synchronization here. The implementation of

Re: Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-13 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27529/ --- (Updated Nov. 13, 2014, 1:56 p.m.) Review request for bookkeeper. Changes

Review Request 27529: BOOKKEEPER-795 Race condition causes writes to hang if ledger is fences

2014-11-03 Thread Ivan Kelly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27529/ --- Review request for bookkeeper. Bugs: BOOKKEEPER-795