[boost] Variant Library Review: implementation issues

2003-04-02 Thread Gennadiy Rozental
Implementation issues comments: > > 2. is_static_visitable description states that this metafunction will > > check whether the specified type is visitable by a static visitor. > > This statement is misleading, cause you do not (and could not ) check > > this. What you check is that type could be

RE: [boost] Variant Library Review

2003-03-29 Thread Eric Friedman
Quoting Gennadiy Rozental: > Here is my a bit late review for the variant library. In spite of > several > concerns that I have, I incline to vote to ACCEPT this submission. Hi Gennadiy, thanks for the comments. I apologize for my late response. [snip] > Design > __

RE: [boost] Variant Library Review

2003-03-04 Thread Rozental, Gennadiy
Hi, Since I did not see a response, I would like to post this reminder to make sure that authors did not miss my review and all issues brought are discussed before the library is added to the boost main trunk. Gennadiy. ___ Unsubscribe & other changes:

[boost] Variant Library Review

2003-03-03 Thread Gennadiy Rozental
Hi, Here is my a bit late review for the variant library. In spite of several concerns that I have, I incline to vote to ACCEPT this submission. Design concerns I would like to be discussed and either accepted or dismissed. Implementation issues are less important. Rest is mostly comments. Here