Re: [brakeman] inline whitelisting?

[Mark Nadig]

Ah, thanks for the answer and the background.
Best,
Mark

On 12/18/14, 12:14 PM, "Justin"  wrote:

>Hi Mark,
>
>In theory, it is possible. However, I do not plan on supporting it in
>Brakeman. If you are interested in the extensive historical discussion
>around this, please see
>https://github.com/presidentbeef/brakeman/pull/73
>
>To summarize: inline annotations are hard for Brakeman interpret, hard
>for external tools to consume, hard for humans to write, and (in my
>opinion) they litter the codebase.
>
>(There are advantages, such as locality and discoverability like you
>mention, but I don't believe the advantages outweigh the disadvantages.)
>
>-Justin
>
>On 2014-12-18 10:14, Mark Nadig wrote:
>> Is there any way to inline warning ignores? Seems having the ignore
>> information far away (brakman.ignore) with line #s makes it more
>> brittle. Having it inline would provide more discoverability as well.
>>
>> Is this possible?
>>
>> Thanks much,
>> Mark Nadig
>>

This e-mail and any attachments are intended only for the named recipient(s) 
and may contain information that is legally privileged, confidential, or exempt 
from disclosure under applicable law. This message may be logged for archival 
purposes, may be reviewed by parties at Deltek other 
than those named in the message header, and may not necessarily constitute an 
official representation of Deltek. If you have received 
this message in error, or are not the named recipient(s), you may not retain 
copy or use this e-mail or any attachment for any purpose or disclose all or 
any part of the contents to any other person. Any such dissemination, 
distribution or copying of this e-mail or its attachments is strictly 
prohibited. Please immediately notify the sender and permanently delete this 
e-mail and any attachment from your computer.

Re: [brakeman] inline whitelisting?

[Justin]

Hi Mark,

In theory, it is possible. However, I do not plan on supporting it in 
Brakeman. If you are interested in the extensive historical discussion 
around this, please see 
https://github.com/presidentbeef/brakeman/pull/73

To summarize: inline annotations are hard for Brakeman interpret, hard 
for external tools to consume, hard for humans to write, and (in my 
opinion) they litter the codebase.

(There are advantages, such as locality and discoverability like you 
mention, but I don't believe the advantages outweigh the disadvantages.)

-Justin

On 2014-12-18 10:14, Mark Nadig wrote:
> Is there any way to inline warning ignores? Seems having the ignore
> information far away (brakman.ignore) with line #s makes it more
> brittle. Having it inline would provide more discoverability as well.
> 
> Is this possible?
> 
> Thanks much,
> Mark Nadig
> 
> This e-mail and any attachments are intended only for the named
> recipient(s) and may contain information that is legally privileged,
> confidential, or exempt from disclosure under applicable law. This
> message may be logged for archival purposes, may be reviewed by
> parties at Deltek [1] other than those named in the message header,
> and may not necessarily constitute an official representation of
> Deltek [1]. If you have received this message in error, or are not the
> named recipient(s), you may not retain copy or use this e-mail or any
> attachment for any purpose or disclose all or any part of the contents
> to any other person. Any such dissemination, distribution or copying
> of this e-mail or its attachments is strictly prohibited. Please
> immediately notify the sender and permanently delete this e-mail and
> any attachment from your computer.
> 
> Links:
> --
> [1] http://www.deltek.com/

[brakeman] inline whitelisting?

[Mark Nadig]

Is there any way to inline warning ignores? Seems having the ignore information 
far away (brakman.ignore) with line #s makes it more brittle. Having it inline 
would provide more discoverability as well.

Is this possible?

Thanks much,
Mark Nadig


This e-mail and any attachments are intended only for the named recipient(s) 
and may contain information that is legally privileged, confidential, or exempt 
from disclosure under applicable law. This message may be logged for archival 
purposes, may be reviewed by parties at Deltek other 
than those named in the message header, and may not necessarily constitute an 
official representation of Deltek. If you have received 
this message in error, or are not the named recipient(s), you may not retain 
copy or use this e-mail or any attachment for any purpose or disclose all or 
any part of the contents to any other person. Any such dissemination, 
distribution or copying of this e-mail or its attachments is strictly 
prohibited. Please immediately notify the sender and permanently delete this 
e-mail and any attachment from your computer.