Re: [brakeman] pruning invalid/unnecessary ignores from brakeman.ignore

2015-08-31 Thread Justin
Hi Carlos,

You are correct, that is current behavior. At the time of implementation 
my thought was it is better to have too much information than to 
accidentally show false positives again.

I don't think automatic pruning is the right way to go, but how about an 
option to prune the file?

-Justin

On 2015-08-31 09:11, Fernandez-Touzon, Carlos E (CTR) wrote:
> Ruby 2.2.3
> 
> Brakeman 3.1.0
> 
> I have noticed that when updating a brakeman.ignore file (brakeman -I
> … then 'Inspect all warnings' … then 'Save changes'), brakeman
> does not prune old invalid/unnecessary ignores from the
> brakeman.ignore file.
> 
> We end up getting a ton of cruft in the file, making it difficult to
> determine what we are actually ignoring.
> 
> Is this expected behavior or am I just brakemanning incorrectly?
> 
> C



[brakeman] pruning invalid/unnecessary ignores from brakeman.ignore

2015-08-31 Thread Fernandez-Touzon, Carlos E (CTR)
Ruby 2.2.3
Brakeman 3.1.0

I have noticed that when updating a brakeman.ignore file (brakeman -I ... then 
'Inspect all warnings' ... then 'Save changes'), brakeman does not prune old 
invalid/unnecessary ignores from the brakeman.ignore file.

We end up getting a ton of cruft in the file, making it difficult to determine 
what we are actually ignoring.

Is this expected behavior or am I just brakemanning incorrectly?

C