Re: [Bridge] [PATCH net v4] net: bridge: Fix ethernet header pointer before check skb forwardable

2019-01-17 Thread David Miller
From: wangyunjian Date: Thu, 17 Jan 2019 09:46:41 +0800 > From: Yunjian Wang > > The skb header should be set to ethernet header before using > is_skb_forwardable. Because the ethernet header length has been > considered in is_skb_forwardable(including dev->hard_header_len > length). > > To

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Toshiaki Makita
On 2019/01/18 4:19, Cong Wang wrote: > On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita > wrote: >> On 2019/01/17 17:17, Zahari Doychev wrote: >>> On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: On 2019/01/13 22:59, Zahari Doychev wrote: > Use the skb->mac_len instead of

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Cong Wang
On Thu, Jan 17, 2019 at 12:59 AM Toshiaki Makita wrote: > > On 2019/01/17 17:17, Zahari Doychev wrote: > > On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: > >> On 2019/01/13 22:59, Zahari Doychev wrote: > >>> Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb

Re: [Bridge] [PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-17 Thread Toshiaki Makita
On 2019/01/17 17:17, Zahari Doychev wrote: > On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote: >> On 2019/01/13 22:59, Zahari Doychev wrote: >>> Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb >>> data pointer. This fixes sending incorrect packets when more