Re: [Bridge] [PATCH net-next] net: bridge: mcast: remove unused br_ip_equal function

2019-04-04 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 3 Apr 2019 23:44:18 +0300 > Since the mcast conversion to rhashtable this function has been unused, so > remove it. > > Signed-off-by: Nikolay Aleksandrov Another reason to not use inline functions in foo.c files :-) Applied, thanks Nikolay.

Re: [Bridge] [PATCH net] net: bridge: always clear mcast matching struct on reports and leaves

2019-04-04 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 3 Apr 2019 23:27:24 +0300 > We need to be careful and always zero the whole br_ip struct when it is > used for matching since the rhashtable change. This patch fixes all the > places which didn't properly clear it which in turn might've caused > mismatches.

Re: [Bridge] [PATCH net-next] net: bridge: optimize backup_port fdb convergence

2019-04-04 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 3 Apr 2019 13:49:24 +0300 > We can optimize the fdb convergence when a backup_port is present by not > immediately flushing the entries of the stopped port since traffic for > those entries will flow towards the backup_port. > > There are 2 cases

Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 4 Apr 2019 13:56:38 +0200 > Simplify this code by updating bridge multicast stats from > maybe_deliver(). > > Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case > the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous >

Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread Nikolay Aleksandrov
On 04/04/2019 15:21, Pablo Neira Ayuso wrote: > On Thu, Apr 04, 2019 at 03:02:19PM +0300, Nikolay Aleksandrov wrote: >> On 04/04/2019 14:56, Pablo Neira Ayuso wrote: >>> Simplify this code by updating bridge multicast stats from >>> maybe_deliver(). >>> >>> Note that commit 6db6f0eae605 ("bridge:

Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread Pablo Neira Ayuso
On Thu, Apr 04, 2019 at 03:02:19PM +0300, Nikolay Aleksandrov wrote: > On 04/04/2019 14:56, Pablo Neira Ayuso wrote: > > Simplify this code by updating bridge multicast stats from > > maybe_deliver(). > > > > Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case > > the port

Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread Nikolay Aleksandrov
On 04/04/2019 15:02, Nikolay Aleksandrov wrote: > On 04/04/2019 14:56, Pablo Neira Ayuso wrote: >> Simplify this code by updating bridge multicast stats from >> maybe_deliver(). >> >> Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case >> the port flag BR_MULTICAST_TO_UNICAST

Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread Nikolay Aleksandrov
On 04/04/2019 14:56, Pablo Neira Ayuso wrote: > Simplify this code by updating bridge multicast stats from > maybe_deliver(). > > Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case > the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous > port pointer,

[Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver()

2019-04-04 Thread Pablo Neira Ayuso
Simplify this code by updating bridge multicast stats from maybe_deliver(). Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous port pointer, therefore it is always going to be different from the existing