Re: [Bridge] [PATCH net] net: bridge: fix netlink export of vlan_stats_per_port option

2019-04-16 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 16 Apr 2019 16:15:56 +0300 > Since the introduction of the vlan_stats_per_port option the netlink > export of it has been broken since I made a typo and used the ifla > attribute instead of the bridge option to retrieve its state. > Sysfs export is fine, only

Re: [Bridge] [PATCH net] net: bridge: fix per-port af_packet sockets

2019-04-16 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 11 Apr 2019 13:56:39 +0300 > When the commit below was introduced it changed two visible things: > - the skb was no longer passed through the protocol handlers with the >original device > - the skb was passed up the stack with skb->dev = bridge > > The

[Bridge] [PATCH net] net: bridge: fix netlink export of vlan_stats_per_port option

2019-04-16 Thread Nikolay Aleksandrov
Since the introduction of the vlan_stats_per_port option the netlink export of it has been broken since I made a typo and used the ifla attribute instead of the bridge option to retrieve its state. Sysfs export is fine, only netlink export has been affected. Fixes: 9163a0fc1f0c0 ("net: bridge:

Re: [Bridge] [PATCH] net:bridge:always disable auto-tuning when the user specified MTU

2019-04-16 Thread 黄睿
Whether use the current method to configure bridge's MTU or add a notification in bridge's internal code and send a notification when modify the bridge's MTU, we all need to add an additional judgement in dev_set_mtu_ext's first if statement for bridge to let the process not return early. By the