Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Ido Schimmel
On Mon, Jul 29, 2019 at 04:35:09PM +0200, Allan W. Nielsen wrote: > The 07/29/2019 17:21, Nikolay Aleksandrov wrote: > > On 29/07/2019 16:52, Allan W. Nielsen wrote: > > > The 07/29/2019 15:50, Nikolay Aleksandrov wrote: > > >> On 29/07/2019 15:22, Nikolay Aleksandrov wrote: > > >>> Hi Allan, > >

Re: [PATCH net v2] net: bridge: delete local fdb on device init failure

2019-07-29 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 29 Jul 2019 12:28:41 +0300 > On initialization failure we have to delete the local fdb which was > inserted due to the default pvid creation. This problem has been present > since the inception of default_pvid. Note that currently there are 2 cases: > 1) in

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Allan W. Nielsen
The 07/29/2019 17:21, Nikolay Aleksandrov wrote: > On 29/07/2019 16:52, Allan W. Nielsen wrote: > > The 07/29/2019 15:50, Nikolay Aleksandrov wrote: > >> On 29/07/2019 15:22, Nikolay Aleksandrov wrote: > >>> Hi Allan, > >>> On 29/07/2019 15:14, Allan W. Nielsen wrote: > First of all, as

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Nikolay Aleksandrov
On 29/07/2019 16:52, Allan W. Nielsen wrote: > The 07/29/2019 15:50, Nikolay Aleksandrov wrote: >> On 29/07/2019 15:22, Nikolay Aleksandrov wrote: >>> Hi Allan, >>> On 29/07/2019 15:14, Allan W. Nielsen wrote: First of all, as mentioned further down in this thread, I realized that our

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Allan W. Nielsen
The 07/29/2019 15:50, Nikolay Aleksandrov wrote: > On 29/07/2019 15:22, Nikolay Aleksandrov wrote: > > Hi Allan, > > On 29/07/2019 15:14, Allan W. Nielsen wrote: > >> First of all, as mentioned further down in this thread, I realized that our > >> implementation of the multicast floodmasks does

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Nikolay Aleksandrov
On 29/07/2019 16:14, Allan W. Nielsen wrote: > The 07/29/2019 15:22, Nikolay Aleksandrov wrote: >> Yes, all of the multicast code is handled differently, it doesn't go through >> the fdb >> lookup or code at all. I don't see how you'll do a lookup in the fdb table >> with a >> multicast mac

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Nikolay Aleksandrov
On 29/07/2019 15:22, Nikolay Aleksandrov wrote: > Hi Allan, > On 29/07/2019 15:14, Allan W. Nielsen wrote: >> Hi Nikolay, >> >> First of all, as mentioned further down in this thread, I realized that our >> implementation of the multicast floodmasks does not align with the existing >> SW >>

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Allan W. Nielsen
Hi Ido, The 07/29/2019 09:09, Ido Schimmel wrote: > External E-Mail > > > On Sun, Jul 28, 2019 at 09:15:59PM +0200, Allan W. Nielsen wrote: > > If we assume that the SwitchDev driver implemented such that all multicast > > traffic goes to the CPU, then we should really have a way to install a

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Nikolay Aleksandrov
Hi Allan, On 29/07/2019 15:14, Allan W. Nielsen wrote: > Hi Nikolay, > > First of all, as mentioned further down in this thread, I realized that our > implementation of the multicast floodmasks does not align with the existing SW > implementation. We will change this, such that all multicast

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Allan W. Nielsen
Hi Nikolay, First of all, as mentioned further down in this thread, I realized that our implementation of the multicast floodmasks does not align with the existing SW implementation. We will change this, such that all multicast packets goes to the SW bridge. This changes things a bit, not that

[PATCH net v2] net: bridge: delete local fdb on device init failure

2019-07-29 Thread Nikolay Aleksandrov
On initialization failure we have to delete the local fdb which was inserted due to the default pvid creation. This problem has been present since the inception of default_pvid. Note that currently there are 2 cases: 1) in br_dev_init() when br_multicast_init() fails 2) if register_netdevice()

Re: [PATCH] net: bridge: Allow bridge to joing multicast groups

2019-07-29 Thread Ido Schimmel
On Sun, Jul 28, 2019 at 09:15:59PM +0200, Allan W. Nielsen wrote: > If we assume that the SwitchDev driver implemented such that all multicast > traffic goes to the CPU, then we should really have a way to install a HW > offload path in the silicon, such that these packets does not go to the CPU