Re: [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-22 Thread David Miller
From: Horatiu Vultur Date: Thu, 22 Aug 2019 21:07:27 +0200 > Current implementation of the SW bridge is setting the interfaces in > promisc mode when they are added to bridge if learning of the frames is > enabled. > In case of Ocelot which has HW capabilities to switch frames, it is not >

Re: [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-22 Thread Nikolay Aleksandrov
On 8/23/19 1:09 AM, Nikolay Aleksandrov wrote: > On 22/08/2019 22:07, Horatiu Vultur wrote: >> Current implementation of the SW bridge is setting the interfaces in >> promisc mode when they are added to bridge if learning of the frames is >> enabled. >> In case of Ocelot which has HW capabilities

Re: [PATCH 1/3] net: Add HW_BRIDGE offload feature

2019-08-22 Thread Andrew Lunn
> +/* Determin if the SW bridge can be offloaded to HW. Return true if all > + * the interfaces of the bridge have the feature NETIF_F_HW_SWITCHDEV set > + * and have the same netdev_ops. > + */ Hi Horatiu Why do you need these restrictions. The HW bridge should be able to learn that a

[PATCH 3/3] net: mscc: Implement promisc mode.

2019-08-22 Thread Horatiu Vultur
Before when a port was added to a bridge then the port was added in promisc mode. But because of the patches: commit 6657c3d812dc5d ("net: Add HW_BRIDGE offload feature") commit e2e3678c292f9c (net: mscc: Use NETIF_F_HW_BRIDGE") the port is not needed to be in promisc mode to be part of the

[PATCH 2/3] net: mscc: Use NETIF_F_HW_BRIDGE

2019-08-22 Thread Horatiu Vultur
Enable HW_BRIDGE feature for ocelot. In this way the HW will do all the switching of the frames so it is not needed for the ports to be in promisc mode. Signed-off-by: Horatiu Vultur --- drivers/net/ethernet/mscc/ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] net: Add HW_BRIDGE offload feature

2019-08-22 Thread Horatiu Vultur
This patch adds a netdev feature to configure the HW as a switch. The purpose of this flag is to show that the hardware can do switching of the frames. Signed-off-by: Horatiu Vultur --- include/linux/netdev_features.h | 3 +++ net/bridge/br_if.c | 29 -