Re: [Bridge] [PATCH v2 0/3] Add NETIF_F_HW_BR_CAP feature

2019-08-26 Thread David Miller
From: Andrew Lunn Date: Mon, 26 Aug 2019 14:38:11 +0200 > I'm still not convinced this is needed. The model is, the hardware is > there to accelerate what Linux can do in software. Any peculiarities > of the accelerator should be hidden in the driver. If the accelerator > can do its job without

Re: [PATCH v2 0/3] Add NETIF_F_HW_BR_CAP feature

2019-08-26 Thread Andrew Lunn
On Mon, Aug 26, 2019 at 10:11:12AM +0200, Horatiu Vultur wrote: > When a network port is added to a bridge then the port is added in > promisc mode. Some HW that has bridge capabilities(can learn, forward, > flood etc the frames) they are disabling promisc mode in the network > driver when the

[PATCH v2 2/3] net: mscc: Use NETIF_F_HW_BR_CAP

2019-08-26 Thread Horatiu Vultur
Enable NETIF_F_HW_BR_CAP feature for ocelot. Because the HW can learn and flood the frames, so there is no need for SW bridge to do this. Signed-off-by: Horatiu Vultur --- drivers/net/ethernet/mscc/ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/3] net: Add NETIF_HW_BR_CAP feature

2019-08-26 Thread Horatiu Vultur
This patch adds a netdev feature to allow the SW bridge not to set all the slave interfaces in promisc mode if the HW is capable of learning and flooading the frames. The current implementation adds all the bridge ports in promisc mode. Even if the HW has bridge capabilities(can learn and flood

[PATCH v2 0/3] Add NETIF_F_HW_BR_CAP feature

2019-08-26 Thread Horatiu Vultur
When a network port is added to a bridge then the port is added in promisc mode. Some HW that has bridge capabilities(can learn, forward, flood etc the frames) they are disabling promisc mode in the network driver when the port is added to the SW bridge. This patch adds the feature

Re: [PATCH] bridge:fragmented packets dropped by bridge

2019-08-26 Thread Jan Engelhardt
On Tuesday 2019-07-30 14:35, Florian Westphal wrote: >Rundong Ge wrote: >> Given following setup: >> -modprobe br_netfilter >> -echo '1' > /proc/sys/net/bridge/bridge-nf-call-iptables >> -brctl addbr br0 >> -brctl addif br0 enp2s0 >> -brctl addif br0 enp3s0 >> -brctl addif br0 enp6s0 >>