Re: [Bridge] [PATCH net-next 0/2] net: bridge: vlan options: nest the tunnel options

2020-03-20 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 20 Mar 2020 13:23:01 +0200 > After a discussion with Roopa about the new tunnel vlan option, she > suggested that we'll be adding more tunnel options and attributes, so > it'd be better to have them all grouped together under one main vlan > entry tunnel

[Bridge] [PATCH net-next 1/2] net: bridge: vlan options: nest the tunnel id into a tunnel info attribute

2020-03-20 Thread Nikolay Aleksandrov
While discussing the new API, Roopa mentioned that we'll be adding more tunnel attributes and options in the future, so it's better to make it a nested attribute, since this is still in net-next we can easily change it and nest the tunnel id attribute under BRIDGE_VLANDB_ENTRY_TUNNEL_INFO. The

[Bridge] [PATCH net-next 2/2] net: bridge: vlan options: move the tunnel command to the nested attribute

2020-03-20 Thread Nikolay Aleksandrov
Now that we have a nested tunnel info attribute we can add a separate one for the tunnel command and require it explicitly from user-space. It must be one of RTM_SETLINK/DELLINK. Only RTM_SETLINK requires a valid tunnel id, DELLINK just removes it if it was set before. This allows us to have all

[Bridge] [PATCH net-next 0/2] net: bridge: vlan options: nest the tunnel options

2020-03-20 Thread Nikolay Aleksandrov
Hi, After a discussion with Roopa about the new tunnel vlan option, she suggested that we'll be adding more tunnel options and attributes, so it'd be better to have them all grouped together under one main vlan entry tunnel attribute instead of making them all main attributes. Since the tunnel