Re: [Bridge] [PATCH net v2 0/2] bridge: mrp: Update MRP_PORT_ROLE

2020-06-23 Thread David Miller
From: Horatiu Vultur Date: Tue, 23 Jun 2020 11:05:39 +0200 > This patch series does the following: > - fixes the enum br_mrp_port_role_type. It removes the port role none(0x2) > because this is in conflict with the standard. The standard defines the > interconnect port role as value 0x2. > -

[Bridge] [PATCH net-next 1/4] net: bridge: fdb_add_entry takes ndm as argument

2020-06-23 Thread Nikolay Aleksandrov
We can just pass ndm as an argument instead of its fields separately. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_fdb.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 4877a0db16c6..ed80d9ab0fb9 100644 ---

[Bridge] [PATCH net-next 3/4] net: bridge: add option to allow activity notifications for any fdb entries

2020-06-23 Thread Nikolay Aleksandrov
This patch adds the ability to notify about activity of any entries (static, permanent or ext_learn). EVPN multihoming peers need it to properly and efficiently handle mac sync (peer active/locally active). We add a new NFEA_ACTIVITY_NOTIFY attribute which is used to dump the current activity

[Bridge] [PATCH net-next 0/4] net: bridge: fdb activity tracking

2020-06-23 Thread Nikolay Aleksandrov
Hi, This set adds extensions needed for EVPN multi-homing proper and efficient mac sync. User-space (e.g. FRR) needs to be able to track non-dynamic entry activity on per-fdb basis depending if a tracked fdb is currently peer active or locally active and needs to be able to add new peer active fdb

[Bridge] [PATCH net-next 2/4] net: neighbor: add fdb extended attribute

2020-06-23 Thread Nikolay Aleksandrov
Add an attribute to NDA which will contain all future fdb-specific attributes in order to avoid polluting the NDA namespace with e.g. bridge or vxlan specific attributes. The attribute is called NDA_FDB_EXT_ATTRS and the structure would look like: [NDA_FDB_EXT_ATTRS] = { [NFEA_xxx] }

[Bridge] [PATCH net-next 4/4] net: bridge: add a flag to avoid refreshing fdb when changing/adding

2020-06-23 Thread Nikolay Aleksandrov
When we modify or create a new fdb entry sometimes we want to avoid refreshing its activity in order to track it properly. One example is when a mac is received from EVPN multi-homing peer by FRR, which doesn't want to change local activity accounting. It makes it static and sets a flag to track

[Bridge] [PATCH net v2 1/2] bridge: uapi: mrp: Fix MRP_PORT_ROLE

2020-06-23 Thread Horatiu Vultur via Bridge
Currently the MRP_PORT_ROLE_NONE has the value 0x2 but this is in conflict with the IEC 62439-2 standard. The standard defines the following port roles: primary (0x0), secondary(0x1), interconnect(0x2). Therefore remove the port role none. Fixes: 4714d13791f831 ("bridge: uapi: mrp: Add mrp

[Bridge] [PATCH net v2 2/2] bridge: mrp: Validate when setting the port role

2020-06-23 Thread Horatiu Vultur via Bridge
This patch adds specific checks for primary(0x0) and secondary(0x1) when setting the port role. For any other value the function 'br_mrp_set_port_role' will return -EINVAL. Fixes: 20f6a05ef63594 ("bridge: mrp: Rework the MRP netlink interface") Signed-off-by: Horatiu Vultur ---

[Bridge] [PATCH net v2 0/2] bridge: mrp: Update MRP_PORT_ROLE

2020-06-23 Thread Horatiu Vultur via Bridge
This patch series does the following: - fixes the enum br_mrp_port_role_type. It removes the port role none(0x2) because this is in conflict with the standard. The standard defines the interconnect port role as value 0x2. - adds checks regarding current defined port roles: primary(0x0) and