Re: [Bridge] [PATCH net-next v4 00/12] bridge: mrp: Add support for interconnect ring

2020-07-14 Thread David Miller
From: Horatiu Vultur Date: Tue, 14 Jul 2020 09:34:46 +0200 > This patch series extends existing MRP to add support for interconnect ring. ... Series applied, thank you.

Re: [Bridge] [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-14 Thread Horatiu Vultur via Bridge
The 07/14/2020 18:33, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 14/07/2020 18:07, Horatiu Vultur wrote: > > The 07/14/2020 16:29, Nikolay Aleksandrov wrote: > >> EXTERNAL EMAIL: Do not click links or open

Re: [Bridge] [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 18:07, Horatiu Vultur wrote: > The 07/14/2020 16:29, Nikolay Aleksandrov wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 14/07/2020 10:34, Horatiu Vultur wrote: >>> This patch adds a new port attribute,

Re: [Bridge] [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-14 Thread Horatiu Vultur via Bridge
The 07/14/2020 16:29, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 14/07/2020 10:34, Horatiu Vultur wrote: > > This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which > > allows to notify the

Re: [Bridge] [PATCH net-next v4 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > Extend switchdev API to add support for MRP interconnect. The HW is > notified in the following cases: > > SWITCHDEV_OBJ_ID_IN_ROLE_MRP: This is used when the interconnect role > of the node changes. The supported roles are MIM and MIC. > >

Re: [Bridge] [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which > allows to notify the userspace when the node lost the contiuity of > MRP_InTest frames. > > Signed-off-by: Horatiu Vultur > --- > include/uapi/linux/if_link.h | 1 + >

Re: [Bridge] [PATCH net-next v4 09/12] bridge: mrp: Extend MRP netlink interface for configuring MRP interconnect

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch extends the existing MRP netlink interface with the following > attributes: IFLA_BRIDGE_MRP_IN_ROLE, IFLA_BRIDGE_MRP_IN_STATE and > IFLA_BRIDGE_MRP_START_IN_TEST. These attributes are similar with their > ring attributes but they apply to the

Re: [Bridge] [PATCH net-next v4 10/12] bridge: uapi: mrp: Extend MRP_INFO attributes for interconnect status

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > Extend the existing MRP_INFO to return status of MRP interconnect. In > case there is no MRP interconnect on the node then the role will be > disabled so the other attributes can be ignored. > > Signed-off-by: Horatiu Vultur > --- >

Re: [Bridge] [PATCH net-next v4 11/12] bridge: mrp: Extend br_mrp_fill_info

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch extends the function br_mrp_fill_info to return also the > status for the interconnect ring. > > Signed-off-by: Horatiu Vultur > --- > net/bridge/br_mrp_netlink.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git

Re: [Bridge] [PATCH net-next v4 07/12] bridge: switchdev: mrp: Extend MRP API for switchdev for MRP Interconnect

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > Implement the MRP API for interconnect switchdev. Similar with the other > br_mrp_switchdev function, these function will just eventually call the > switchdev functions: switchdev_port_obj_add/del. > > Signed-off-by: Horatiu Vultur > --- >

Re: [Bridge] [PATCH net-next v4 08/12] bridge: mrp: Implement the MRP Interconnect API

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > Thie patch adds support for MRP Interconnect. Similar with the MRP ring, > if the HW can't generate MRP_InTest frames, then the SW will try to > generate them. And if also the SW fails to generate the frames then an > error is return to userspace. > >

Re: [Bridge] [PATCH net-next v4 06/12] bridge: mrp: Add br_mrp_in_port_open function

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This function notifies the userspace when the node lost the continuity > of MRP_InTest frames. > > Signed-off-by: Horatiu Vultur > --- > net/bridge/br_mrp_netlink.c | 22 ++ > net/bridge/br_private_mrp.h | 1 + > 2 files changed,

Re: [Bridge] [PATCH net-next v4 03/12] bridge: mrp: Extend bridge interface

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch adds a new flag(BR_MRP_LOST_IN_CONT) to the net bridge > ports. This bit will be set when the port lost the continuity of > MRP_InTest frames. > > Signed-off-by: Horatiu Vultur > --- > include/linux/if_bridge.h | 1 + > 1 file changed, 1

Re: [Bridge] [PATCH net-next v4 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > Extend the existing MRP netlink attributes to allow to configure MRP > Interconnect: > > IFLA_BRIDGE_MRP_IN_ROLE - the parameter type is br_mrp_in_role which > contains the interconnect id, the ring id, the interconnect role(MIM > or MIC) and the

Re: [Bridge] [PATCH net-next v4 04/12] bridge: mrp: Extend br_mrp for MRP interconnect

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch extends the 'struct br_mrp' to contain information regarding > the MRP interconnect. It contains the following: > - the interconnect port 'i_port', which is NULL if the node doesn't have > a interconnect role > - the interconnect id, which

Re: [Bridge] [PATCH net-next v4 05/12] bridge: mrp: Rename br_mrp_port_open to br_mrp_ring_port_open

2020-07-14 Thread Nikolay Aleksandrov
On 14/07/2020 10:34, Horatiu Vultur wrote: > This patch renames the function br_mrp_port_open to > br_mrp_ring_port_open. In this way is more clear that a ring port lost > the continuity because there will be also a br_mrp_in_port_open. > > Signed-off-by: Horatiu Vultur > --- >

[Bridge] [PATCH net-next v4 10/12] bridge: uapi: mrp: Extend MRP_INFO attributes for interconnect status

2020-07-14 Thread Horatiu Vultur via Bridge
Extend the existing MRP_INFO to return status of MRP interconnect. In case there is no MRP interconnect on the node then the role will be disabled so the other attributes can be ignored. Signed-off-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 5 + 1 file changed, 5 insertions(+)

[Bridge] [PATCH net-next v4 09/12] bridge: mrp: Extend MRP netlink interface for configuring MRP interconnect

2020-07-14 Thread Horatiu Vultur via Bridge
This patch extends the existing MRP netlink interface with the following attributes: IFLA_BRIDGE_MRP_IN_ROLE, IFLA_BRIDGE_MRP_IN_STATE and IFLA_BRIDGE_MRP_START_IN_TEST. These attributes are similar with their ring attributes but they apply to the interconnect port. Signed-off-by: Horatiu Vultur

[Bridge] [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-14 Thread Horatiu Vultur via Bridge
This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which allows to notify the userspace when the node lost the contiuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c| 3 +++

[Bridge] [PATCH net-next v4 04/12] bridge: mrp: Extend br_mrp for MRP interconnect

2020-07-14 Thread Horatiu Vultur via Bridge
This patch extends the 'struct br_mrp' to contain information regarding the MRP interconnect. It contains the following: - the interconnect port 'i_port', which is NULL if the node doesn't have a interconnect role - the interconnect id, which is similar with the ring id, but this field is also

[Bridge] [PATCH net-next v4 07/12] bridge: switchdev: mrp: Extend MRP API for switchdev for MRP Interconnect

2020-07-14 Thread Horatiu Vultur via Bridge
Implement the MRP API for interconnect switchdev. Similar with the other br_mrp_switchdev function, these function will just eventually call the switchdev functions: switchdev_port_obj_add/del. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_switchdev.c | 62

[Bridge] [PATCH net-next v4 03/12] bridge: mrp: Extend bridge interface

2020-07-14 Thread Horatiu Vultur via Bridge
This patch adds a new flag(BR_MRP_LOST_IN_CONT) to the net bridge ports. This bit will be set when the port lost the continuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- include/linux/if_bridge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/if_bridge.h

[Bridge] [PATCH net-next v4 11/12] bridge: mrp: Extend br_mrp_fill_info

2020-07-14 Thread Horatiu Vultur via Bridge
This patch extends the function br_mrp_fill_info to return also the status for the interconnect ring. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_netlink.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c

[Bridge] [PATCH net-next v4 05/12] bridge: mrp: Rename br_mrp_port_open to br_mrp_ring_port_open

2020-07-14 Thread Horatiu Vultur via Bridge
This patch renames the function br_mrp_port_open to br_mrp_ring_port_open. In this way is more clear that a ring port lost the continuity because there will be also a br_mrp_in_port_open. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp.c | 6 +++--- net/bridge/br_mrp_netlink.c | 2

[Bridge] [PATCH net-next v4 06/12] bridge: mrp: Add br_mrp_in_port_open function

2020-07-14 Thread Horatiu Vultur via Bridge
This function notifies the userspace when the node lost the continuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_netlink.c | 22 ++ net/bridge/br_private_mrp.h | 1 + 2 files changed, 23 insertions(+) diff --git a/net/bridge/br_mrp_netlink.c

[Bridge] [PATCH net-next v4 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

2020-07-14 Thread Horatiu Vultur via Bridge
Extend the existing MRP netlink attributes to allow to configure MRP Interconnect: IFLA_BRIDGE_MRP_IN_ROLE - the parameter type is br_mrp_in_role which contains the interconnect id, the ring id, the interconnect role(MIM or MIC) and the port ifindex that represents the interconnect port.

[Bridge] [PATCH net-next v4 08/12] bridge: mrp: Implement the MRP Interconnect API

2020-07-14 Thread Horatiu Vultur via Bridge
Thie patch adds support for MRP Interconnect. Similar with the MRP ring, if the HW can't generate MRP_InTest frames, then the SW will try to generate them. And if also the SW fails to generate the frames then an error is return to userspace. The forwarding/termination of MRP_In frames is

[Bridge] [PATCH net-next v4 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect

2020-07-14 Thread Horatiu Vultur via Bridge
Extend switchdev API to add support for MRP interconnect. The HW is notified in the following cases: SWITCHDEV_OBJ_ID_IN_ROLE_MRP: This is used when the interconnect role of the node changes. The supported roles are MIM and MIC. SWITCHDEV_OBJ_ID_IN_STATE_MRP: This is used when the interconnect

[Bridge] [PATCH net-next v4 00/12] bridge: mrp: Add support for interconnect ring

2020-07-14 Thread Horatiu Vultur via Bridge
This patch series extends existing MRP to add support for interconnect ring. An interconnect ring is a ring that connects 2 rings. In this way is possible to connect multiple rings. Each interconnect ring is form of 4 nodes, in which 3 have the role MIC(Media Redundancy Interconnect Client) and