Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-20 Thread Hangbin Liu
On Wed, Oct 20, 2021 at 08:19:37AM -0700, Stephen Hemminger wrote: > > On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote: > > > > I started this patch when I saw there is not limit for setting > > > > multicast_membership_interval to 0, which will cause bridge remove the > > > >

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-20 Thread Stephen Hemminger
On Wed, 20 Oct 2021 09:02:01 +0800 Hangbin Liu wrote: > On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote: > > > I started this patch when I saw there is not limit for setting > > > multicast_membership_interval to 0, which will cause bridge remove the > > > mdb directly after

Re: [Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

2021-10-20 Thread Nikolay Aleksandrov via Bridge
On 20/10/2021 15:10, Hangbin Liu wrote: > On Wed, Oct 20, 2021 at 06:19:25PM +0800, Hangbin Liu wrote: >> On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov wrote: >>> Nacked-by: Nikolay Aleksandrov >>> >>> I think we just discussed this a day ago? It is the same problem - >>> while we

Re: [Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

2021-10-20 Thread Hangbin Liu
On Wed, Oct 20, 2021 at 06:19:25PM +0800, Hangbin Liu wrote: > On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov wrote: > > Nacked-by: Nikolay Aleksandrov > > > > I think we just discussed this a day ago? It is the same problem - > > while we all agree the values should follow the

Re: [Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

2021-10-20 Thread Hangbin Liu
On Wed, Oct 20, 2021 at 12:49:17PM +0300, Nikolay Aleksandrov wrote: > Nacked-by: Nikolay Aleksandrov > > I think we just discussed this a day ago? It is the same problem - > while we all agree the values should follow the RFC, users have had > the option to set any values forever (even non-RFC

Re: [Bridge] [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

2021-10-20 Thread Nikolay Aleksandrov via Bridge
On 20/10/2021 05:40, Hangbin Liu wrote: > Based on RFC3376 8.3: > The number of seconds represented by the [Query Response Interval] > must be less than the [Query Interval]. > > Fixes: d902eee43f19 ("bridge: Add multicast count/interval sysfs entries") > Signed-off-by: Hangbin Liu > --- >