Re: [Bridge] [PATCH v2 net] bridge: Add extack warning when enabling STP in netns.

On Wed, Jul 12, 2023 at 08:44:49AM -0700, Kuniyuki Iwashima wrote: > When we create an L2 loop on a bridge in netns, we will see packets storm > even if STP is enabled. > > # unshare -n > # ip link add br0 type bridge > # ip link add veth0 type veth peer name veth1 > # ip link set veth0 ma

Re: [Bridge] [PATCH v2 net] bridge: Add extack warning when enabling STP in netns.

On 12/07/2023 18:44, Kuniyuki Iwashima wrote: > When we create an L2 loop on a bridge in netns, we will see packets storm > even if STP is enabled. > > # unshare -n > # ip link add br0 type bridge > # ip link add veth0 type veth peer name veth1 > # ip link set veth0 master br0 up > # ip

[Bridge] [PATCH v2 net] bridge: Add extack warning when enabling STP in netns.

When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled. # unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge s

Re: [Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

From: Ido Schimmel Date: Wed, 12 Jul 2023 17:48:20 +0300 > On Tue, Jul 11, 2023 at 04:54:15PM -0700, Kuniyuki Iwashima wrote: > > When we create an L2 loop on a bridge in netns, we will see packets storm > > even if STP is enabled. > > > > # unshare -n > > # ip link add br0 type bridge > >

Re: [Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

On Tue, Jul 11, 2023 at 04:54:15PM -0700, Kuniyuki Iwashima wrote: > When we create an L2 loop on a bridge in netns, we will see packets storm > even if STP is enabled. > > # unshare -n > # ip link add br0 type bridge > # ip link add veth0 type veth peer name veth1 > # ip link set veth0 ma

Re: [Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

On Wed, Jul 12, 2023 at 05:52:09PM +0300, Nikolay Aleksandrov wrote: > I'd prefer this approach to changing user-visible behaviour and potential > regressions. > Just change the warning message. Yea, I noticed after sending that the message no longer fits :)

Re: [Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

On 12/07/2023 17:48, Ido Schimmel wrote: > On Tue, Jul 11, 2023 at 04:54:15PM -0700, Kuniyuki Iwashima wrote: >> When we create an L2 loop on a bridge in netns, we will see packets storm >> even if STP is enabled. >> >> # unshare -n >> # ip link add br0 type bridge >> # ip link add veth0 type

Re: [Bridge] llc needs namespace awareness asap, was Re: Patch fixing STP if bridge in non-default namespace.

(CC'ing bridge maintainers.) Kuniyuki Iwashima writes: > From: Harry Coin > Date: Tue, 11 Jul 2023 16:40:03 -0500 >> On 7/11/23 15:44, Andrew Lunn wrote: >> >> The current llc_rcv.c around line 166 in net/llc/llc_input.c has >> >> >> >>if (!net_eq(dev_net(dev), &init_ne

[Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.

When we create an L2 loop on a bridge in netns, we will see packets storm even if STP is enabled. # unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up # ip link set veth1 master br0 up # ip link set br0 type bridge s