From: Cong Wang amw...@redhat.com
Date: Tue, 23 Mar 2010 10:13:43 +0800
Matt Mackall wrote:
Seems like a lot of interface for something to be used by only a
couple
core drivers. Hopefully Dave has an opinion here.
Yeah, I worry about this too, maybe we can group those methods
for
From: Cong Wang amw...@redhat.com
Date: Tue, 23 Mar 2010 12:39:35 +0800
How could you let the bridge know netpoll is not sent to
the one that doesn't support netpoll during setup? This will
be complex, I am afraid.
Why does this matter at all?
I told you in another mail that we should do
From: Cong Wang amw...@redhat.com
Date: Tue, 23 Mar 2010 12:47:39 +0800
Yeah, for bonding case, probably. But for bridge case, I think
we still need to check all, right?
Why? Who cares?
If it goes out one port and reaches it's destination
the objective has been achieved.
Sending it out N
From: Matt Mackall m...@selenic.com
Date: Mon, 22 Mar 2010 23:51:01 -0500
On Tue, 2010-03-23 at 12:39 +0800, Cong Wang wrote:
Matt Mackall wrote:
How could you let the bridge know netpoll is not sent to
the one that doesn't support netpoll during setup? This will
be complex, I am afraid.
From: Herbert Xu herb...@gondor.apana.org.au
Date: Sat, 20 Mar 2010 19:57:47 +0800
On Sat, Mar 20, 2010 at 02:20:49PM +0300, Dan Carpenter wrote:
We never actually use iph again so this assignment can be removed.
Signed-off-by: Dan Carpenter erro...@gmail.com
Acked-by: Herbert Xu
From: Stephen Hemminger shemmin...@vyatta.com
Date: Tue, 2 Mar 2010 15:32:09 -0800
The shared packet statistics are a potential source of slow down
on bridged traffic. Convert to per-cpu array, but only keep those
statistics which change per-packet.
Signed-off-by: Stephen Hemminger
From: Henrik Kretzschmar he...@nachtwindheim.de
Date: Sat, 13 Mar 2010 22:10:11 +0100
Linking the kernel fails with the the following error message,
if CONFIG_BRIDGE_IGMP_SNOOPING is set and CONFIG_INET is not set.
net/built-in.o: In function `br_multicast_alloc_query':
From: Herbert Xu herb...@gondor.apana.org.au
Date: Sat, 6 Mar 2010 20:20:32 +0800
On Sat, Mar 06, 2010 at 02:14:09PM +0300, Dan Carpenter wrote:
We dereference port on the lines immediately before and immediately
after the test so port should hopefully never be null here.
Signed-off-by:
From: Ingo Molnar mi...@elte.hu
Date: Thu, 4 Mar 2010 04:18:47 +0100
I suspect Randy went by the MAINTAINERS entry - you might want to add netdev
as a second 'L:' line:
ETHERNET BRIDGE
M: Stephen Hemminger shemmin...@linux-foundation.org
L: bridge@lists.linux-foundation.org
From: Eric Dumazet eric.duma...@gmail.com
Date: Wed, 03 Mar 2010 07:09:04 +0100
Le mardi 02 mars 2010 à 15:32 -0800, Stephen Hemminger a écrit :
The shared packet statistics are a potential source of slow down
on bridged traffic. Convert to per-cpu array, but only keep those
statistics which
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Fri, 26 Feb 2010 10:01:02 -0800
TCP connections are never really bound to device. TCP routing is
flexible; if packets can get through, it doesn't care.
I think he might be talking about SO_BINDTODEVICE
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Fri, 26 Feb 2010 10:30:03 -0800
On Fri, 26 Feb 2010 10:08:00 -0800 (PST)
David Miller da...@davemloft.net wrote:
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Fri, 26 Feb 2010 10:01:02 -0800
TCP connections
From: Arnd Bergmann a...@arndb.de
Date: Sat, 30 Jan 2010 23:22:15 +0100
This is the fourth version of the macvtap driver,
based on the comments I got for the last version
I got a few days ago. Very few changes:
* release netdev in chardev open function so
we can destroy it properly.
*
From: Arnd Bergmann a...@arndb.de
Date: Sat, 28 Nov 2009 00:43:58 +0100
On Friday 13 November 2009, Stephen Hemminger wrote:
Also, macvlan should really being calling netif_receive_skb()
not going through another queue/softirq cycle.
I've added a patch for this in my experimental queue now.
From: Stephen Hemminger shemmin...@vyatta.com
Date: Fri, 27 Nov 2009 21:38:24 -0800
Maybe we should figure out a way for protocols to return new skb in
netif_receive_skb
to avoid extra softirq, but avoid stack overflow?
Eric Dumazet and I tried to find ways to handle this, please see the
From: Patrick McHardy ka...@trash.net
Date: Thu, 26 Nov 2009 17:26:17 +0100
Arnd Bergmann wrote:
Version 2 description:
The patch to iproute2 has not changed, so I'm not including
it this time. Patch 4/4 (the netlink interface) is basically
unchanged as well but included for completeness.
From: Fischer, Anna anna.fisc...@hp.com
Date: Thu, 13 Aug 2009 16:55:16 +
This patch adds a 'hairpin' (also called 'reflective relay') mode
port configuration to the Linux Ethernet bridge kernel module.
A bridge supporting hairpin forwarding mode can send frames back
out through the port
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Fri, 24 Jul 2009 08:36:07 -0700
On Fri, 24 Jul 2009 17:06:32 +0800
Xiaotian Feng df...@redhat.com wrote:
kobject_init_and_add will alloc memory for kobj-name, so in br_add_if
error path, simply use kobject_del will not free
From: Stephen Hemminger shemmin...@vyatta.com
Date: Fri, 15 May 2009 09:11:58 -0700
If bridge is configured with no STP and forwarding delay of 0 (which
is typical for virtualization) then when link starts it will flood all
packets for the first 20 seconds.
This bug was introduced by a
From: Stephen Hemminger shemmin...@vyatta.com
Date: Fri, 8 May 2009 15:38:42 -0700
Not sure if this is such a good idea since the purpose of this was to fix
a bonding/bridging interaction, but it breaks STP on bridging.
Thanks for not paying attention... :-/
The Intel folks want to have an
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Wed, 6 May 2009 12:26:45 -0700
Won't this all break spanning tree which expects 1:1 relationship
between address and port.
Indeed, this could be a fundamental issue with this change.
___
From: Jiri Pirko jpi...@redhat.com
Date: Wed, 15 Apr 2009 10:32:24 +0200
This patch introduces a new list in struct net_device and brings a set of
functions to handle the work with device address list. The list is a
replacement
for the original dev_addr field and because in some situations
From: Eric Dumazet da...@cosmosbay.com
Date: Wed, 15 Apr 2009 11:27:50 +0200
Since you obviously need a write lock here to be sure following
can be done by one cpu only.
You have same problem all over this patch.
RTNL semaphore is held across all modification operations.
From: Patrick McHardy ka...@trash.net
Date: Wed, 15 Apr 2009 12:41:01 +0200
Herbert (I think) suggested to make address list updates in softirq
context a two-step process, where addresses would first be added to
a temporary list and the final change would be done in process context
while
From: Jiri Pirko jpi...@redhat.com
Date: Mon, 13 Apr 2009 10:42:02 +0200
@@ -210,6 +210,12 @@ struct dev_addr_list
#define dmi_usersda_users
#define dmi_gusers da_gusers
+struct hw_addr {
+ struct list_headlist;
+ unsigned char addr[MAX_ADDR_LEN];
+
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Mon, 13 Apr 2009 07:49:17 -0700
This lock is unnecessary, use RCU list for read.
Since all changes are under RTNL mutex, there is no chance
for conflict on update.
Agreed.
___
Bridge
From: Jiri Pirko jpi...@redhat.com
Date: Thu, 26 Mar 2009 16:52:06 +0100
(resend, updated changelog, hook moved into skb_bond_should_drop,
skb_bond_should_drop ifdefed)
Hi all.
The problem is described in following bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=487763
...
This
From: Li Yang le...@freescale.com
Date: Fri, 20 Mar 2009 17:04:29 +0800
The bridging device used a constant hard_header_len. This will cause
headroom shortage for ports with additional hardware header. The patch
makes bridging device to use the maximum value of all ports.
Signed-off-by:
From: Li Yang le...@freescale.com
Date: Wed, 25 Mar 2009 15:05:20 +0800
On Wed, Mar 25, 2009 at 2:40 PM, David Miller da...@davemloft.net wrote:
From: Li Yang le...@freescale.com
Date: Fri, 20 Mar 2009 17:04:29 +0800
The bridging device used a constant hard_header_len. This will cause
From: Li Yang le...@freescale.com
Date: Wed, 25 Mar 2009 16:43:53 +0800
Dynamically adjusting is a good idea, but the rx_alloc_extra can only
go up not the other way down in your code.
That's not a problem.
Another thought is that if you re-allocate skb here the driver would
be saved from
From: Li Yang le...@freescale.com
Date: Mon, 23 Mar 2009 16:15:34 +0800
I was wondering if this one failed to get your attention.
yeah, happens all the time
___
Bridge mailing list
Bridge@lists.linux-foundation.org
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Mon, 23 Mar 2009 08:51:22 -0700
That ensures big enough header for locally generated packets, but
any drivers that need bigger headroom still must handle bridged packets
that come in with smaller space. When bridging packets, the
From: Stephen Hemminger shemmin...@linux-foundation.org
Date: Mon, 23 Mar 2009 15:45:17 -0700
So you dynamically compute the additional space but if the space was
an awkward size, could it cause driver to breaks alignment assumptions?
Yes, you'd need to 16-byte align or something like that.
From: Jiri Pirko jpi...@redhat.com
Date: Mon, 16 Mar 2009 12:11:28 +0100
I can see two solutions. Either like my patch or somehow allow bridge to know
more MAC addressses per port (maybe netdev can be changed to know more then
one MAC address).
Any thoughts?
The netdev struct already
From: Jiri Pirko jpi...@redhat.com
Date: Thu, 19 Mar 2009 09:44:45 +0100
Yes I was looking at this thing yesterday (uc_list). But this list serves
to different purpose. Do you think that it will be correct to use it for
this? I
would maybe like to make a new list similar to this for our
From: Henk Stegeman henk.stege...@gmail.com
Date: Wed, 18 Feb 2009 11:41:14 +0100
Please CC: netdev, now added, on all networking reports and patches.
Thank you.
I discovered the hard way that because linux bridging uses
net_device_ops, bridging only works with network drivers that publish
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 4 Sep 2008 15:47:09 -0700
The bridge hello time can't be safely set to values less than 1 second,
otherwise it is possible to end up with a runaway timer.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied, thanks Stephen.
I
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Sun, 31 Aug 2008 10:43:09 -0700
The Spanning Tree Protocol timers need to be set within certain boundaries
to keep the internal protocol engine working, and to be interoperable.
This patch restricts changes to those timers to the values defined
From: Bill Nottingham [EMAIL PROTECTED]
Date: Mon, 7 Jul 2008 17:34:20 -0400
I could look at wireless network configuration, but I doubt that's going to
help your argument.
Just like any system with age, we have a lot of legacy to
convert over. But it will happen.
That being said, how is
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 2 Jul 2008 09:48:17 -0700
On Wed, 02 Jul 2008 15:04:14 +0200
Patrick McHardy [EMAIL PROTECTED] wrote:
commit 96f1dd78dad10d61bdd487edadea6adda5425e4c
Author: Patrick McHardy [EMAIL PROTECTED]
Date: Wed Jul 2 15:02:23 2008 +0200
From: Jan Engelhardt [EMAIL PROTECTED]
Date: Thu, 27 Sep 2007 16:55:36 +0200 (CEST)
On Sep 27 2007 07:51, Stephen Hemminger wrote:
You need every socket to close and all routes to go away including the
routes through loopback device, and still there probably are control
sockets buried
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 17 Apr 2007 13:37:23 -0700
The previous patch relied on the bridge id being aligned by
the compiler (which happens as a side effect). So please use
this instead.
compare_ether_addr() implicitly requires that the addresses
passed are
401 - 442 of 442 matches
Mail list logo
