Re: [Bridge] [PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread David Miller
From: Colin King Date: Sun, 25 Nov 2018 16:08:51 + > From: Colin Ian King > > A recent change added a null check on p->dev after p->dev was being > dereferenced by the ns_capable check on p->dev. It turns out that > neither the p->dev and p->br null checks are necessary, and can be >

Re: [Bridge] [PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread Nikolay Aleksandrov
On 25/11/2018 18:08, Colin King wrote: > From: Colin Ian King > > A recent change added a null check on p->dev after p->dev was being > dereferenced by the ns_capable check on p->dev. It turns out that > neither the p->dev and p->br null checks are necessary, and can be > removed, which cleans

[Bridge] [PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread Colin King
From: Colin Ian King A recent change added a null check on p->dev after p->dev was being dereferenced by the ns_capable check on p->dev. It turns out that neither the p->dev and p->br null checks are necessary, and can be removed, which cleans up a static analyis warning. As Nikolay Aleksandrov