Re: [Bridge] [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-24 Thread Stephen Hemminger
On Thu, 22 Aug 2019 21:07:27 +0200 Horatiu Vultur wrote: > Current implementation of the SW bridge is setting the interfaces in > promisc mode when they are added to bridge if learning of the frames is > enabled. > In case of Ocelot which has HW capabilities to switch frames, it is not > needed t

Re: [Bridge] [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-23 Thread Horatiu Vultur
Hi Andrew The 08/23/2019 15:25, Andrew Lunn wrote: > External E-Mail > > > > > > Why do the devices have to be from the same driver ? > > After seeing yours and Andrews comments I realize that I try to do two > > things, but I have only explained one of them. > > > > Here is what I was trying t

Re: [Bridge] [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-23 Thread Andrew Lunn
> > > Why do the devices have to be from the same driver ? > After seeing yours and Andrews comments I realize that I try to do two > things, but I have only explained one of them. > > Here is what I was trying to do: > A. Prevent ports from going into promisc mode, if it is not needed. The switc

Re: [Bridge] [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-23 Thread Horatiu Vultur
The 08/23/2019 01:26, Nikolay Aleksandrov wrote: > External E-Mail > > > On 8/23/19 1:09 AM, Nikolay Aleksandrov wrote: > > On 22/08/2019 22:07, Horatiu Vultur wrote: > >> Current implementation of the SW bridge is setting the interfaces in > >> promisc mode when they are added to bridge if learn

[Bridge] [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-22 Thread Horatiu Vultur
Current implementation of the SW bridge is setting the interfaces in promisc mode when they are added to bridge if learning of the frames is enabled. In case of Ocelot which has HW capabilities to switch frames, it is not needed to set the ports in promisc mode because the HW already capable of doi