Re: [Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-10-03 Thread netdev
On 2022-10-01 17:38, Ido Schimmel wrote: Need to patch the "SYNOPSIS" section as well Does this look right to you for the addition to the "SYNOPSIS"?... bridge fdb { add | del } LLADR dev BRDEV [ self ] [ local ] [ blackhole ]

Re: [Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-10-01 Thread netdev
On 2022-10-01 17:38, Ido Schimmel wrote: I'm not sure the last sentence belongs in the man page. We have no way of knowing if it is true and it can change with time. How about: "this entry will silently discard all matching packets. The entry must be added as a local permanent entry." Fine

Re: [Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-10-01 Thread Ido Schimmel via Bridge
On Thu, Sep 29, 2022 at 05:21:37PM +0200, Hans Schultz wrote: > Block traffic to a specific host with the command: > bridge fdb add vlan dev br0 blackhole Please add an example with regular and JSON output. > > The blackhole FDB entries can be added, deleted and replaced with > ordinary FDB en

Re: [Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-09-29 Thread netdev
On 2022-09-29 17:43, Stephen Hemminger wrote: On Thu, 29 Sep 2022 17:21:37 +0200 Hans Schultz wrote: @@ -493,6 +496,8 @@ static int fdb_modify(int cmd, int flags, int argc, char **argv) req.ndm.ndm_flags |= NTF_EXT_LEARNED; } else if (matches(*argv, "

Re: [Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-09-29 Thread Stephen Hemminger via Bridge
On Thu, 29 Sep 2022 17:21:37 +0200 Hans Schultz wrote: > > @@ -493,6 +496,8 @@ static int fdb_modify(int cmd, int flags, int argc, char > **argv) > req.ndm.ndm_flags |= NTF_EXT_LEARNED; > } else if (matches(*argv, "sticky") == 0) { > re

[Bridge] [PATCH iproute2-next 2/2] bridge: fdb: enable FDB blackhole feature

2022-09-29 Thread Hans Schultz
Block traffic to a specific host with the command: bridge fdb add vlan dev br0 blackhole The blackhole FDB entries can be added, deleted and replaced with ordinary FDB entries. Signed-off-by: Hans Schultz --- bridge/fdb.c | 7 ++- include/uapi/linux/neighbour.h | 4