Re: [Bridge] [PATCH net-next 0/7] net: bridge: convert fdbs to use bitops

2019-10-31 Thread Joe Perches
On Tue, 2019-10-29 at 13:45 +0200, Nikolay Aleksandrov wrote: > Hi, > We'd like to have a well-defined behaviour when changing fdb flags. The > problem is that we've added new fields which are changed from all > contexts without any locking. We are aware of the bit test/change races > and these

Re: [Bridge] [PATCH net-next 0/7] net: bridge: convert fdbs to use bitops

2019-10-31 Thread Nikolay Aleksandrov
On 31/10/2019 20:37, Joe Perches wrote: > On Tue, 2019-10-29 at 13:45 +0200, Nikolay Aleksandrov wrote: >> Hi, >> We'd like to have a well-defined behaviour when changing fdb flags. The >> problem is that we've added new fields which are changed from all >> contexts without any locking. We are

Re: [Bridge] [PATCH net-next 0/7] net: bridge: convert fdbs to use bitops

2019-10-29 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 29 Oct 2019 13:45:52 +0200 > We'd like to have a well-defined behaviour when changing fdb flags. The > problem is that we've added new fields which are changed from all > contexts without any locking. We are aware of the bit test/change races > and these are

[Bridge] [PATCH net-next 0/7] net: bridge: convert fdbs to use bitops

2019-10-29 Thread Nikolay Aleksandrov
Hi, We'd like to have a well-defined behaviour when changing fdb flags. The problem is that we've added new fields which are changed from all contexts without any locking. We are aware of the bit test/change races and these are fine (we can remove them later), but it is considered undefined