Re: [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-18 Thread Johannes Nixdorf via Bridge
On Mon, May 15, 2023 at 08:56:27AM -0700, Stephen Hemminger wrote: > On Mon, 15 May 2023 10:50:46 +0200 > Johannes Nixdorf wrote: > > > +static struct ctl_table br_sysctl_table[] = { > > + { > > + .procname = "bridge-fdb-max-entries-default", > > > That name is too long. > > Al

Re: [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-18 Thread Johannes Nixdorf via Bridge
On Mon, May 15, 2023 at 12:35:47PM +0300, Nikolay Aleksandrov wrote: > On 15/05/2023 11:50, Johannes Nixdorf wrote: > > This is a convenience setting, which allows the administrator to limit > > the default limit of FDB entries for all created bridges, instead of > > having to set it for each creat

[Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-18 Thread Johannes Nixdorf via Bridge
This is a convenience setting, which allows the administrator to limit the default limit of FDB entries for all created bridges, instead of having to set it for each created bridge using the netlink property. The setting is network namespace local, and defaults to 0, which means unlimited, for bac

Re: [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-16 Thread Nikolay Aleksandrov
On 15/05/2023 14:27, Johannes Nixdorf wrote: > On Mon, May 15, 2023 at 12:35:47PM +0300, Nikolay Aleksandrov wrote: >> On 15/05/2023 11:50, Johannes Nixdorf wrote: >>> This is a convenience setting, which allows the administrator to limit >>> the default limit of FDB entries for all created bridges

Re: [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-15 Thread Stephen Hemminger via Bridge
On Mon, 15 May 2023 10:50:46 +0200 Johannes Nixdorf wrote: > +static struct ctl_table br_sysctl_table[] = { > + { > + .procname = "bridge-fdb-max-entries-default", That name is too long. Also, all the rest of bridge code does not use sysctl's. Why is this special and why s

Re: [Bridge] [PATCH net-next 2/2] bridge: Add a sysctl to limit new brides FDB entries

2023-05-15 Thread Nikolay Aleksandrov
On 15/05/2023 11:50, Johannes Nixdorf wrote: > This is a convenience setting, which allows the administrator to limit > the default limit of FDB entries for all created bridges, instead of > having to set it for each created bridge using the netlink property. > > The setting is network namespace l