On 26/11/2018 19:39, Stephen Hemminger wrote:
> On Sun, 25 Nov 2018 10:12:45 +0200
> Nikolay Aleksandrov wrote:
>
>> On 24/11/2018 18:46, niko...@cumulusnetworks.com wrote:
>>> On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusne
On Sun, 25 Nov 2018 10:12:45 +0200
Nikolay Aleksandrov wrote:
> On 24/11/2018 18:46, niko...@cumulusnetworks.com wrote:
> > On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
> >> On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com
> >> wrote:
> >>> On 24 November 2018 18
On Sat, Nov 24, 2018 at 04:34:20AM +0200, Nikolay Aleksandrov wrote:
> We have been adding many new bridge options, a big number of which are
> boolean but still take up netlink attribute ids and waste space in the skb.
> Recently we discussed learning from link-local packets[1] and decided
> yet a
On 24/11/2018 18:46, niko...@cumulusnetworks.com wrote:
> On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
>> On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com
>> wrote:
>>> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
> +int br_boolopt_toggle(struct net_bridge
On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
>On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com
>wrote:
>> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
>> >> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id
>opt,
>> >bool on,
>> >> +
On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com wrote:
> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
> >> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt,
> >bool on,
> >> +struct netlink_ext_ack *extack)
> >> +{
> >> + switch (o
On 24 November 2018 18:10:41 EET, Andrew Lunn wrote:
>> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt,
>bool on,
>> + struct netlink_ext_ack *extack)
>> +{
>> +switch (opt) {
>> +default:
>> +/* shouldn't be called with unsupported option
> +int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt, bool on,
> + struct netlink_ext_ack *extack)
> +{
> + switch (opt) {
> + default:
> + /* shouldn't be called with unsupported options */
> + WARN_ON(1);
> + break;
We have been adding many new bridge options, a big number of which are
boolean but still take up netlink attribute ids and waste space in the skb.
Recently we discussed learning from link-local packets[1] and decided
yet another new boolean option will be needed, thus introducing this API
to save s
