Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Andrew Lunn
On Fri, Jan 10, 2020 at 09:12:48PM +0100, Horatiu Vultur wrote: > The 01/10/2020 18:56, Andrew Lunn wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > > > Horatiu, could you also give some references to the frames that need > > > >

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Horatiu Vultur
> >With a userland implementation, what approach do you suggest for > >DSA/switchdev offload > >of this stuff? > > Good question, there was no mention of that initially, or I missed it at > least. > There aren't many details about what/how will be offloaded right now. > We need more information

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Horatiu Vultur
The 01/10/2020 18:56, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > > Horatiu, could you also give some references to the frames that need > > > to be sent. I've no idea what information they need to contain, if the > > >

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread nikolay
On 10 January 2020 21:27:36 EET, David Miller wrote: >From: Nikolay Aleksandrov >Date: Fri, 10 Jan 2020 16:13:36 +0200 > >> I agree with Stephen here, IMO you have to take note of how STP has >progressed >> and that bringing it in the kernel was a mistake, these days mstpd >has an active >>

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 10 Jan 2020 16:13:36 +0200 > I agree with Stephen here, IMO you have to take note of how STP has progressed > and that bringing it in the kernel was a mistake, these days mstpd has an > active > community and much better support which is being extended. This

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Andrew Lunn
> > Horatiu, could you also give some references to the frames that need > > to be sent. I've no idea what information they need to contain, if the > > contents is dynamic, or static, etc. > It is dynamic - but trivial... If it is trivial, i don't see why you are so worried about abstracting it?

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Horatiu Vultur
Hi Valdimir and Andrew The 01/10/2020 18:21, Vladimir Oltean wrote: > I think it would help your case if you explained a bit more about the > hw offload primitives you have implemented internally. I believe you > are talking about the frame generation engine in the Ocelot switch > which has

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Andrew Lunn
> I think it would help your case if you explained a bit more about > the hw offload primitives you have implemented internally. Agreed. Horatiu, could you also give some references to the frames that need to be sent. I've no idea what information they need to contain, if the contents is

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Vladimir Oltean
Hi Horatiu, On Fri, 10 Jan 2020 at 18:04, Horatiu Vultur wrote: > > Hi Nik, > > > I agree with Stephen here, IMO you have to take note of how STP has > > progressed > > and that bringing it in the kernel was a mistake, these days mstpd has an > > active > > community and much better support

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Horatiu Vultur
Hi Nik, > I agree with Stephen here, IMO you have to take note of how STP has progressed > and that bringing it in the kernel was a mistake, these days mstpd has an > active > community and much better support which is being extended. This looks best > implemented > in user-space in my opinion

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Nikolay Aleksandrov
On 10/01/2020 16:13, Nikolay Aleksandrov wrote: > On 09/01/2020 17:06, Horatiu Vultur wrote: >> Media Redundancy Protocol is a data network protocol standardized by >> International Electrotechnical Commission as IEC 62439-2. It allows rings of >> Ethernet switches to overcome any single failure

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Stephen Hemminger
On Fri, 10 Jan 2020 10:02:06 +0100 Horatiu Vultur wrote: > > > > Can this be implemented in userspace? > > The reason for putting this in kernal space is to HW offload this in > switchdev/dsa driver. The switches which typically supports this are > small and don't have a lot of CPU power and

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Nikolay Aleksandrov
On 09/01/2020 17:06, Horatiu Vultur wrote: > Media Redundancy Protocol is a data network protocol standardized by > International Electrotechnical Commission as IEC 62439-2. It allows rings of > Ethernet switches to overcome any single failure with recovery time faster > than > STP. It is

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-10 Thread Horatiu Vultur
The 01/09/2020 08:19, Stephen Hemminger wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, 9 Jan 2020 16:06:37 +0100 > Horatiu Vultur wrote: > > > Media Redundancy Protocol is a data network protocol standardized by > >

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-09 Thread Asbjørn Sloth Tønnesen via Bridge
Hi Horatiu and Stephen, Horatiu, thanks for giving this a try. I am looking forward to maybe someday be able to run ERPS on white box switches. On 1/9/20 4:19 PM, Stephen Hemminger wrote: Can this be implemented in userspace? Putting STP in the kernel was a mistake (even original author says

Re: [Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-09 Thread Stephen Hemminger
On Thu, 9 Jan 2020 16:06:37 +0100 Horatiu Vultur wrote: > Media Redundancy Protocol is a data network protocol standardized by > International Electrotechnical Commission as IEC 62439-2. It allows rings of > Ethernet switches to overcome any single failure with recovery time faster > than >

[Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)

2020-01-09 Thread Horatiu Vultur
Media Redundancy Protocol is a data network protocol standardized by International Electrotechnical Commission as IEC 62439-2. It allows rings of Ethernet switches to overcome any single failure with recovery time faster than STP. It is primarily used in Industrial Ethernet applications. This is