Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Rafał Miłecki writes: >>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; >>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) >> >> #ifndef? > > I followed what is used in the include/linux/etherdevice.h. Is that a > good exceuse? Could it be there any some

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 15:24, Kalle Valo wrote: Rafał Miłecki writes: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Arend van Spriel writes: > On 3/14/2018 3:24 PM, Kalle Valo wrote: >>> +config BRCMFMAC_IAPP >>> >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >>> >+ depends on BRCMFMAC >>> >+ ---help--- >>> >+Most of Broadcom's firmwares can send

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's firmwares can send 802.11f ADD frame every >+ time new STA connects to the AP interface. Some

[Bridge] [PATCH] net: bridge: add missing NULL checks

br_port_get_rtnl() can return NULL Signed-off-by: Laszlo Toth --- net/bridge/br_netlink.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 015f465c..cbec11f 100644 ---

[Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network with: 1) IFLA_BRPORT_MCAST_TO_UCAST 2) Clients isolation in hostapd 3) Hairpin mode enabled For more details please see Linus's patch

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network with: 1) IFLA_BRPORT_MCAST_TO_UCAST 2) Clients isolation in hostapd 3) Hairpin mode enabled

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 03/13/2018 12:01 AM, Stephen Hemminger wrote: On Mon, 12 Mar 2018 23:42:48 +0100 Rafał Miłecki wrote: 2) Blame bridge + mcast-to-ucast + hairpin for 802.11f incompatibility If we agree that 802.11f support in FullMAC firmware is acceptable, then we have to make sure

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 12 March 2018 at 12:48, Linus Lüssing wrote: > On Mon, Mar 12, 2018 at 12:08:56PM +0100, Linus Lüssing wrote: >> On Tue, Feb 27, 2018 at 11:08:20AM +0100, Rafał Miłecki wrote: >> > I've problem when using OpenWrt/LEDE on a home router with Broadcom's >> > FullMAC WiFi

[Bridge] WARNING: kobject bug in br_add_if

Hello, syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link:

Re: [Bridge] [PATCH] net: bridge: add missing NULL checks

On Mon, Apr 09, 2018 at 01:25:41AM +0300, Nikolay Aleksandrov wrote: > On 08/04/18 20:49, Laszlo Toth wrote: > >br_port_get_rtnl() can return NULL > > > >Signed-off-by: Laszlo Toth > >--- > > net/bridge/br_netlink.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 2/27/2018 11:14 AM, Rafał Miłecki wrote: Sending with a fixed linux-wireless ML address. Please kindly send your replies using linux-wireless@ On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

Sending with a fixed linux-wireless ML address. Please kindly send your replies using linux-wireless@ On 02/27/2018 11:08 AM, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for

[Bridge] Traffic shaping with bridge.

Hi, I'm having some problem to make traffic shaping work with bridge, the topology is below, the same script to set the delay/loss works for 10.34.201.45 and 10.35.201.47, but not working for 10.35.200.2. I use ifb device for traffic control, say for example, adding 300ms delay for dst

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 4:57 PM, Rafał Miłecki wrote: On 2018-03-14 16:39, Rafał Miłecki wrote: On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 16:08, Kalle Valo wrote: Arend van Spriel writes: On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 28 February 2018 at 12:31, Arend van Spriel wrote: > On 2/27/2018 11:14 AM, Rafał Miłecki wrote: >> >> Sending with a fixed linux-wireless ML address. Please kindly send your >> replies using linux-wireless@ >> >> On 02/27/2018 11:08 AM, Rafał Miłecki wrote: >>>

[Bridge] KASAN: stack-out-of-bounds Write in compat_copy_entries

Hello, syzbot hit the following crash on upstream commit 24cac7009cb1b211f1c793ecb6a462c03dc35818 (Tue Apr 24 21:16:40 2018 +) Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=4e42a04e0bc33cb6c087 So far this

[Bridge] KMSAN: uninit-value in ebt_stp_mt_check

Hello, syzbot hit the following crash on https://github.com/google/kmsan.git/master commit a7f95e9c8a95e9fbb388c3999b61a17667cd3bbe (Sat Apr 21 13:50:22 2018 +) kmsan: disable assembly checksums syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=5c06e318fc558cc27823 So far

Re: [Bridge] [PATCH V2] brcmfmac: drop Inter-Access Point Protocol packets by default

On 15 March 2018 at 08:29, Rafał Miłecki wrote: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares.

[Bridge] [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync_static()

With gcc-4.1.2.: net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’: net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this function Indeed, if the list is empty, err will be uninitialized, and will be propagated up as the function return value. Fix this by

[Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standard and its implementation is something that: 1)

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standard

Re: [Bridge] Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

On 3/13/2018 8:20 AM, Felix Fietkau wrote: [resent with fixed typo in linux-wireless address] On 2018-02-27 11:08, Rafał Miłecki wrote: I've problem when using OpenWrt/LEDE on a home router with Broadcom's FullMAC WiFi chipset. First of all OpenWrt/LEDE uses bridge interface for LAN network

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Rafał Miłecki writes: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. This is an obsoleted

[Bridge] [PATCH V2] brcmfmac: drop Inter-Access Point Protocol packets by default

From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. Older firmwares were only generating 802.11f frames. Newer ones like: 1)

Re: [Bridge] [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 5:10 PM, Kalle Valo wrote: Rafał Miłecki writes: + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifndef? I followed what is used in the include/linux/etherdevice.h. Is that a good

Re: [Bridge] BUG: unable to handle kernel paging request in compat_copy_entries

On Mon, Mar 05, 2018 at 04:18:00PM +0100, Paolo Abeni wrote: > On Mon, 2018-03-05 at 00:21 -0800, syzbot wrote: > > Hello, > > > > syzbot hit the following crash on upstream commit > > 5fbdefcf685defd8bc5a8f37b17538d25c58d77a (Fri Mar 2 21:05:20 2018 +) > > Merge branch 'parisc-4.16-1' of >

Re: [Bridge] BUG: unable to handle kernel paging request in compat_copy_entries

On Mon, 2018-03-05 at 00:21 -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 5fbdefcf685defd8bc5a8f37b17538d25c58d77a (Fri Mar 2 21:05:20 2018 +) > Merge branch 'parisc-4.16-1' of > git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux > >

Re: [Bridge] WARNING in kobject_add_internal

Hi, I have a question, "can syzbot auto test each tree with newest changeset" ? > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Dmitry Vyukov > Sent: Wednesday, April 11, 2018 10:58 PM > To: syzbot > Cc: