Revision: 50316 http://brlcad.svn.sourceforge.net/brlcad/?rev=50316&view=rev Author: brlcad Date: 2012-04-26 12:49:55 +0000 (Thu, 26 Apr 2012) Log Message: ----------- looks like coverity thinks fastf_t is not a floating point type. cast through double. should finally fix cid 328 false positive.
Modified Paths: -------------- brlcad/trunk/src/liboptical/sh_toyota.c Modified: brlcad/trunk/src/liboptical/sh_toyota.c =================================================================== --- brlcad/trunk/src/liboptical/sh_toyota.c 2012-04-26 03:56:55 UTC (rev 50315) +++ brlcad/trunk/src/liboptical/sh_toyota.c 2012-04-26 12:49:55 UTC (rev 50316) @@ -1860,13 +1860,13 @@ fclose(fp); - abso1 = absorp_h - absorp_l; - /* double to avoid coverity overflow warning */ + /* double casts to avoid coverity overflow warning */ + abso1 = (double)absorp_h - (double)absorp_l; lamb1 = (double)lambda - (double)lambda_l; - lamb2 = lambda_h - lambda_l; - lambrat = lamb1 / lamb2; - absorp = abso1 * lambrat; - absorp += absorp_l; + lamb2 = (double)lambda_h - (double)lambda_l; + lambrat = (double)lamb1 / (double)lamb2; + absorp = (double)abso1 * (double)lambrat; + absorp += (double)absorp_l; return absorp; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits