Revision: 69131 http://sourceforge.net/p/brlcad/code/69131 Author: brlcad Date: 2016-10-19 04:35:41 +0000 (Wed, 19 Oct 2016) Log Message: ----------- setting a nul char isn't right, almost certainly masking a real bug that was caught. bu_vls_putc() and other vls printing functions already manually nul-terminate and bu_vls_cstr() is defined to guarantee only returning a nul-terminated string. so any vls string lacking 0-termination would be a bug.
Modified Paths: -------------- brlcad/trunk/src/libbu/tests/bu_bitv.c Modified: brlcad/trunk/src/libbu/tests/bu_bitv.c =================================================================== --- brlcad/trunk/src/libbu/tests/bu_bitv.c 2016-10-19 04:25:11 UTC (rev 69130) +++ brlcad/trunk/src/libbu/tests/bu_bitv.c 2016-10-19 04:35:41 UTC (rev 69131) @@ -56,7 +56,6 @@ char c = chars[n]; bu_vls_putc(v, c); } - bu_vls_putc(v, '\0'); if (typ == HEX) { bu_vls_prepend(v, "0x"); @@ -478,7 +477,7 @@ bu_log("\nbitv dump:"); bu_log("\n nbits = %zu", len); - NEXT: +NEXT: k = i + x; bu_log("\n---------------------------------------------------------------------"); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits