Re: [Bro-Dev] Broker & CAF includes

2016-03-31 Thread Siwek, Jon
> On Mar 25, 2016, at 11:16 AM, Matthias Vallentin wrote: > > At this point, I'm inclined to move towards a more light-weight model > that is less robust against ABI changes. I believe we still need more > experience with the API. Once the API matures, hiding central >

Re: [Bro-Dev] Broker & CAF includes

2016-03-25 Thread Matthias Vallentin
> Providing stable-ish ABIs seems like something libraries often do, so > I tried to plan that in to Broker. Don’t know if I did that well, or > there’s better strategies to use, or I was the only one worried about > that to begin with, but thought I’d mention it just in case it wasn’t > even on

Re: [Bro-Dev] Broker & CAF includes

2016-03-24 Thread Siwek, Jon
> On Mar 21, 2016, at 12:36 PM, Matthias Vallentin wrote: > > The "implementation detail" maxim lead to artifacts like PIMPL. This > certainly made sense at the time where we considered multiple messaging > backends. At this point, we are invested into CAF, and I don't think

Re: [Bro-Dev] Broker & CAF includes

2016-03-21 Thread Robin Sommer
On Mon, Mar 21, 2016 at 10:36 -0700, you wrote: > That's fine in my thinking, because anyone developing and compiling a > Broker application must have CAF installed anyway. Yeah, I agree, sounds like the right strategy at this point. Robin -- Robin Sommer * ICSI/LBNL * ro...@icir.org *

Re: [Bro-Dev] Broker & CAF includes

2016-03-21 Thread Matthias Vallentin
Thanks for chiming in, Jon. > [..] i.e. treat the use of CAF an implementation detail. This is the clean way to think about layering and creating abstractions. It applies to the API perspective, though. As long as CAF internals are hidden from a Broker user, we are good. The "implementation

Re: [Bro-Dev] Broker & CAF includes

2016-03-21 Thread Siwek, Jon
> On Mar 18, 2016, at 10:20 PM, Matthias Vallentin wrote: > > During Broker refactoring, I noticed the following: all headers in > broker/* include either standard library headers or Broker headers. This > appears to be by design, which makes sense to me. > > As a library

Re: [Bro-Dev] Broker & CAF includes

2016-03-18 Thread Craig Leres
This all makes sense to me; what you describe as the current situation (two packages defining the same data structure) seems broken to me. And I see caf/config.hpp defines CAF_VERSION so you're set if broker now or in the future requires a minimum version of caf. Craig