Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread Stefan Karlsson
Hi David, On 10/05/16 02:33, David Holmes wrote: Okay here is version 2: http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/ Lots of cosmetic changes but only a couple of functional ones: - After thread->run() returns we clear the TLS by calling clear_thread_current(), but only for threa

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread David Holmes
Hi Stefan, Thanks for looking at this again. On 10/05/2016 6:24 PM, Stefan Karlsson wrote: Hi David, On 10/05/16 02:33, David Holmes wrote: Okay here is version 2: http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/ Lots of cosmetic changes but only a couple of functional ones: - After

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread Stefan Karlsson
Hi David, On 10/05/16 12:17, David Holmes wrote: Hi Stefan, Thanks for looking at this again. On 10/05/2016 6:24 PM, Stefan Karlsson wrote: Hi David, On 10/05/16 02:33, David Holmes wrote: Okay here is version 2: http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/ Lots of cosmetic chan

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread Brian Gardner
I really like the rename of java_start to native_thread_entry, it makes things make more sense. It looks like os_bsd.cpp and os_linux.cpp are both missing the clear_thread_current logic after thread->run(). + // If a thread has not deleted itself ("delete this") as part of its + // terminatio

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread David Holmes
On 11/05/2016 6:28 AM, Brian Gardner wrote: I really like the rename of java_start to native_thread_entry, it makes things make more sense. It looks like os_bsd.cpp and os_linux.cpp are both missing the clear_thread_current logic after thread->run(). Doh! Thanks. That's what I get for trying t

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread Brian Gardner
Looks good to me, and fixes my issues. Thanks David! Brian > On May 10, 2016, at 7:17 PM, David Holmes wrote: > > On 11/05/2016 6:28 AM, Brian Gardner wrote: >> I really like the rename of java_start to native_thread_entry, it makes >> things make more sense. It looks like os_bsd.cpp and os_

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread David Holmes
On 11/05/2016 1:42 PM, serguei.spit...@oracle.com wrote: David, It looks good and safe. Thanks Serguei! Is there anything to do for the closed code as well? No. David Thanks, Serguei On 5/10/16 19:17, David Holmes wrote: On 11/05/2016 6:28 AM, Brian Gardner wrote: I really like the

Re: RFR: 8154715: Missing destructor and/or TLS clearing calls for terminating threads

2016-05-10 Thread David Holmes
On 11/05/2016 2:11 PM, Brian Gardner wrote: Looks good to me, and fixes my issues. Thanks David! Thanks Brian! I will list you as a co-contributor. David Brian On May 10, 2016, at 7:17 PM, David Holmes wrote: On 11/05/2016 6:28 AM, Brian Gardner wrote: I really like the rename of java