tached JVM patch was sufficient as a proof of concept.
We implemented the basic patch, we don't do anything to ensure it was
called at most twice. We expect all well behaving apps to detach threads
from the JVM before they terminate.
David
-
On Mar 17, 2016,
Thomas writes:
Hi Brian,
The next patches where less straightforward. When running java I was
getting a ton of messages like:
Thread 832744400 has exited with leftover thread-specific data after 4
destructor iterations
After doing a lot of digging and debugging on Linux, I found the code path
for that.
Thanks,
David
-
Kind regards,
Brian Gardner
On Mar 18, 2016, at 2:57 PM, David Holmes mailto:david.hol...@oracle.com>> wrote:
On 19/03/2016 2:58 AM, Brian Gardner wrote:
That explains the destructor. Looking at the initial change set that
came out of this bug, we also see the
e::set_thread(NULL). I’m going to do some more
research to locate the change sets for these calls. Perhaps they are
isolated to bsd-port branch. I’ll let everyone know what I find.
Kind regards,
Brian Gardner
On Mar 18, 2016, at 2:57 PM, David Holmes mailto:david.hol...@oracle.com>> wro
A further followup/clarification ...
On 21/03/2016 8:20 AM, David Holmes wrote:
Sorry I didn't seem this before my previous reply ...
On 21/03/2016 4:53 AM, Brian Gardner wrote:
I looked into the origination of other calls to set_thread(NULL) in
openjdk8.
*
hotspot/src/sha
FYI I filed:
https://bugs.openjdk.java.net/browse/JDK-8154715
David
-
On 21/03/2016 10:45 AM, David Holmes wrote:
A further followup/clarification ...
On 21/03/2016 8:20 AM, David Holmes wrote:
Sorry I didn't seem this before my previous reply ...
On 21/03/2016 4:53 AM, Brian Ga
This needs attention from GC and runtime folk please.
bug: https://bugs.openjdk.java.net/browse/JDK-8154715
webrev: http://cr.openjdk.java.net/~dholmes/8154715/webrev/
tl;dr: ensure ThreadLocalStorage::set_thread(NULL) is always called
before a thread terminates.
Background:
Most system-rela
PING!
David
On 4/05/2016 9:39 AM, David Holmes wrote:
This needs attention from GC and runtime folk please.
bug: https://bugs.openjdk.java.net/browse/JDK-8154715
webrev: http://cr.openjdk.java.net/~dholmes/8154715/webrev/
tl;dr: ensure ThreadLocalStorage::set_thread(NULL) is always called
Hi Dan,
Thanks for the Review!
On 6/05/2016 8:03 AM, Daniel D. Daugherty wrote:
On 5/3/16 5:39 PM, David Holmes wrote:
This needs attention from GC and runtime folk please.
bug: https://bugs.openjdk.java.net/browse/JDK-8154715
webrev: http://cr.openjdk.java.net/~dholmes/8154715/webrev/
src
--
log_info(os, thread)("Thread finished (tid: " UINTX_FORMAT ", pthread
id: " UINTX_FORMAT ").",
os::current_thread_id(), (uintx) pthread_self());
return 0;
}
And get rid of the explicit calls to
ThreadLocalStorage::set_thread(NULL) you added?
Thanks,
Stef
On 7/05/2016 12:04 AM, Stefan Karlsson wrote:
Hi David,
On 06/05/16 15:38, David Holmes wrote:
Hi Stefan,
Thanks for taking a look at this.
On 6/05/2016 5:02 PM, Stefan Karlsson wrote:
Hi David,
I looked through the GC part of this webrev and I think the change is
fine.
However, it seems
On 7/05/2016 1:41 AM, Stefan Karlsson wrote:
On 06/05/16 16:32, David Holmes wrote:
On 7/05/2016 12:04 AM, Stefan Karlsson wrote:
Hi David,
On 06/05/16 15:38, David Holmes wrote:
Hi Stefan,
Thanks for taking a look at this.
On 6/05/2016 5:02 PM, Stefan Karlsson wrote:
Hi David,
I looked
s references to 'this', but we must do some cleanup
88 // ourselves before allowing the native thread to terminate
89
90 ThreadLocalStorage::set_thread(NULL);
91 }
so you should not be seeing any issue because of that.
???
David
Brian
On May 3, 2016, at 4:39 PM, Davi
vid
Brian
On May 6, 2016, at 8:41 AM, Stefan Karlsson
mailto:stefan.karls...@oracle.com>> wrote:
On 06/05/16 16:32, David Holmes wrote:
On 7/05/2016 12:04 AM, Stefan Karlsson wrote:
Hi David,
On 06/05/16 15:38, David Holmes wrote:
Hi Stefan,
Thanks for taking a look at this.
On 6/05/
to that of the VMThread.
I'll do a new version on Monday. I also need to double-check those
threads that don't use java_start (which I am sorely tempted to rename).
Thanks,
David
On 7/05/2016 9:50 AM, David Holmes wrote:
On 7/05/2016 5:40 AM, Brian Gardner wrote:
I agree with Stefan.
v ready but have run into a weird build problem.
Thanks,
David
StefanK
On 2016-05-07 07:45, David Holmes wrote:
Brian, Stefan,
I've been giving this more thought and I think you are both right.
While this can't be completely handled in java_start for all threads
it can handle the mos
Okay here is version 2:
http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/
Lots of cosmetic changes but only a couple of functional ones:
- After thread->run() returns we clear the TLS by calling
clear_thread_current(), but only for threads where it has not already
been cleared - as thos
Hi Stefan,
Thanks for looking at this again.
On 10/05/2016 6:24 PM, Stefan Karlsson wrote:
Hi David,
On 10/05/16 02:33, David Holmes wrote:
Okay here is version 2:
http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/
Lots of cosmetic changes but only a couple of functional ones
r_thread_current();
+ }
+
On May 9, 2016, at 5:33 PM, David Holmes mailto:david.hol...@oracle.com>> wrote:
Okay here is version 2:
http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/
Lots of cosmetic changes but only a couple of functional ones:
- After thread->r
On 11/05/2016 1:42 PM, serguei.spit...@oracle.com wrote:
David,
It looks good and safe.
Thanks Serguei!
Is there anything to do for the closed code as well?
No.
David
Thanks,
Serguei
On 5/10/16 19:17, David Holmes wrote:
On 11/05/2016 6:28 AM, Brian Gardner wrote:
I really like the
On 11/05/2016 2:11 PM, Brian Gardner wrote:
Looks good to me, and fixes my issues. Thanks David!
Thanks Brian! I will list you as a co-contributor.
David
Brian
On May 10, 2016, at 7:17 PM, David Holmes wrote:
On 11/05/2016 6:28 AM, Brian Gardner wrote:
I really like the rename of
Forwarding to bsd-dev-port, but I don't think there is any active work
being done on this port at the moment.
David
--- Begin Message ---
Hi,
here a little patch proposal to improve slightly the BSD support.
Thanks.
Kind regards.
# HG changeset patch
# User David Carlier
# Date 1558430500 0
22 matches
Mail list logo
