On 04/29/2013 12:18 PM, Stefano Lattarini wrote:
On 04/29/2013 08:11 AM, Pavel Raiskup wrote:
Hi!
I have re-introduced the line removed by mistake.
It seems to be completely OK now,
Thanks, I will push shortly then, barring further objections.
thanks a LOT for your patience.
I think
Hi!
I have re-introduced the line removed by mistake.
It seems to be completely OK now, thanks a LOT for your patience. I don't
see any problems and also all test passes for me.
Have a nice day,
Pavel
On 04/26/2013 08:29 PM, Stefano Lattarini wrote:
On 04/26/2013 01:48 PM, Pavel Raiskup wrote:
Actually, I prefer to keep the checks distinct, and output the problematic
UID/GID as well (makes debugging easier). So I'd rather drop the squash-in
patch you proposed.
No problem :).
I'm also
Stefano, this patch is quite hard to follow because of the new
indentation. But both checks are saying PASS for me now.
I have found one possible problem (missing one line):
-done
-am__tar=$_am_tar --format=m4_if([$1], [pax], [posix], [$1]) -chf -
'$$tardir'
-am__tar_=$_am_tar
Hi, I'm just thinking aloud here.. I'm ok with this.
Marc Herbert marc.herb...@intel.com adds (in bug#8343):
When configure is run by a user with an UID bigger than 21 bits,
BSD pax 3.4 aborts when trying to create the 'conftest.tar' test
archive and leaves an empty or corrupted
On 2013-04-25 14:19, Stefano Lattarini wrote:
*snip*
* THANKS: Likewise.
* t/tar-ustar-id-too-high.sh: New test.
* t/list-of-tests.mk: Add it.
* t/tar2.sh: While at it, tweak and enhance a little.
* t/tar3.sh: Likewise.
* t/tar-override.sh: Likewise.
Helped-by: Pavel Raiskup
On 04/26/2013 01:03 PM, Peter Rosin wrote:
On 2013-04-25 14:19, Stefano Lattarini wrote:
*snip*
* THANKS: Likewise.
* t/tar-ustar-id-too-high.sh: New test.
* t/list-of-tests.mk: Add it.
* t/tar2.sh: While at it, tweak and enhance a little.
* t/tar3.sh: Likewise.
* t/tar-override.sh:
Actually, I prefer to keep the checks distinct, and output the problematic
UID/GID as well (makes debugging easier). So I'd rather drop the squash-in
patch you proposed.
No problem :).
I'm also quite afraid of testsuite performance of testsuite - this
check costs more than 6 seconds..
On 04/26/2013 01:48 PM, Pavel Raiskup wrote:
Actually, I prefer to keep the checks distinct, and output the problematic
UID/GID as well (makes debugging easier). So I'd rather drop the squash-in
patch you proposed.
No problem :).
I'm also quite afraid of testsuite performance of
Hi, thanks a lot for working on this! I would like to point some notes,
sorry for doing it so late..
diff --git a/m4/tar.m4 b/m4/tar.m4
index ec8c83e..61c1206 100644
--- a/m4/tar.m4
+++ b/m4/tar.m4
@@ -81,7 +81,31 @@ do
AM_RUN_LOG([tardir=conftest.dir eval $am__tar_ conftest.tar])
On 04/22/2013 03:55 PM, Stefano Lattarini wrote:
Hi Peter, thanks for the feedback.
On 04/22/2013 03:21 PM, Petr Hracek wrote:
Hello Stefano,
thanks for the patch. All is working properly.
User is informed that UID is not enough smaller and configure script does
not failed.
Good to
Hello Stefano,
I was a little bit busy.
From my point of view user is not informed that his UID is too big. I
think that it should be mentioned and visible directly on the screen.
But as I mentioned it is my point of view.
Here are results:
test@kiasportyw: ~/mycproject$ ./configure
checking
On 04/23/2013 05:04 PM, Petr Hracek wrote:
Hello Stefano,
I was a little bit busy.
No worries.
From my point of view user is not informed that his UID is too big.
I think that it should be mentioned and visible directly on the screen.
But then, following the same logic, we should also
Hello Stefano,
thanks for the patch. All is working properly.
User is informed that UID is not enough smaller and configure script
does not failed.
Result is below:
test@localhost: ~/mycproject$ id
uid=1700(test) gid=1001(test) groups=1001(test)
Hi Peter, thanks for the feedback.
On 04/22/2013 03:21 PM, Petr Hracek wrote:
Hello Stefano,
thanks for the patch. All is working properly.
User is informed that UID is not enough smaller and configure script does not
failed.
Good to know the logic is sound. However, I now notice that
tags 13588 + patch
stop
[+cc automake-patches]
Hi Jack, Petr, sorry for the ludicrous delay.
On 03/22/2013 02:39 AM, Jack Kelly wrote:
Petr Hracek phra...@redhat.com writes:
Hello Jack and Stefano,
Bellow is corrected patch for automake.
Jack thank you for corrections. Now the patch
Hello Jack and Stefano,
Bellow is corrected patch for automake.
Jack thank you for corrections. Now the patch looks like better.
From 98a64a309a0f7271d2772dd63e45e43b1163c315 Mon Sep 17 00:00:00 2001
From: Petr Hracek phra...@redhat.com
Date: Thu, 21 Mar 2013 13:27:39 +0100
Subject: [PATCH]
Hello Stefano,
in order to help you with that bug I have prepared patch for that issue:
diff --git a/m4/tar.m4 b/m4/tar.m4
index ec8c83e..87477f1 100644
--- a/m4/tar.m4
+++ b/m4/tar.m4
@@ -81,6 +81,27 @@ do
AM_RUN_LOG([tardir=conftest.dir eval $am__tar_ conftest.tar])
rm -rf conftest.dir
Hello Stefano,
one more time. wrong patch file name.
[stone@kiasportyw automake(master)]$ cat
0001-maint-pax-hangs-in-case-big-UID.patch
From af7d2d01b363914ce22628dae06f87065649d402 Mon Sep 17 00:00:00 2001
From: Petr Hracek phra...@redhat.com
Date: Wed, 20 Mar 2013 12:41:30 +0100
Subject:
Hi Petr, I have a couple of observations:
- AC_MSG_ERROR is going to stop the configure anyway, so you don't need
exit 1.
- I'd suggest the following messages for your AC_MSG_ERRORS:
the uid is too large for ustar-format tarfiles. Change format in
configure.ac
the gid is too large for
Hello Jack,
that's sound better than my proposed patched.
It's shorter and more understandable.
Yes you are right that user should be informed for testing ustar format.
Best regards
Petr
On 03/20/2013 12:55 PM, Jack Kelly wrote:
Hi Petr, I have a couple of observations:
- AC_MSG_ERROR is
tags 13588 + patch
tags 8343 + patch
merge 13588 8343
thanks
Merging with bug#8343, since it's the same issue
Regards,
Stefano
Hi Petr!
On 2013-02-05 13:00, Petr Hracek wrote:
just a one question regarding that problem
Can that patch applicable?
As far as I can tell, the patch has other problems, but
since those would be more obvious to whomever was going to
shepherd this patch in (and I'm not what person) I didn't
Hi Petr,
I have looked at this only cursory, but FWIW,
On 2013-01-30 14:31, Petr Hracek wrote:
*snip*
+AC_SUBST([AM_BIG_ID], [2097152])
*snip*
+#Test if $user_id is greater then 2^21
s/then/than/
And please add a space after the comment hash-marks.
+#if yes then failed.
On 01/30/2013 02:45 PM, Peter Rosin wrote:
Hi Petr,
I have looked at this only cursory, but FWIW,
On 2013-01-30 14:31, Petr Hracek wrote:
*snip*
+AC_SUBST([AM_BIG_ID], [2097152])
*snip*
+#Test if $user_id is greater then 2^21
s/then/than/
And please add a space after the comment
25 matches
Mail list logo
