bug#8718: error when using nested conditionals

2011-06-16 Thread Ralf Wildenhues
* Bruno Haible wrote on Thu, Jun 16, 2011 at 11:42:51PM CEST: > > > AM_CONDITIONAL([USE_VARIANT_A], [$use_variant_a]) > > > > Instead of this line, you could use > > AC_CONFIG_COMMANDS_PRE([AM_CONDITIONAL([...])]) > > I cannot force the gnulib users to write autoconf macros which deviate that

bug#8881: config.h double inclusion

2011-06-16 Thread Bruno Haible
Alfred M. Szmidt wrote: > I think that autoconf should have the guard for double inclusion. Autoconf does not need to provide a double-inclusion guard for config.h, because those packages that need it can get it through use of AH_TOP and AH_BOTTOM. Bruno -- In memoriam Imre Nagy

bug#8881: config.h double inclusion

2011-06-16 Thread Alfred M. Szmidt
>> I'm thinking that maybe should be generated with a double >> inclusion guard > > But the general rule is that must always be included first, no? > So there shouldn't ever be a possibility of including it twice. > > It might be better to have config.h do something like this

bug#8881: config.h double inclusion

2011-06-16 Thread Alfred M. Szmidt
> I'm thinking that maybe should be generated with a double > inclusion guard But the general rule is that must always be included first, no? So there shouldn't ever be a possibility of including it twice. Right, which is the case in inetutils in all places where we use . The p

bug#8881: config.h double inclusion

2011-06-16 Thread Jack Kelly
On Fri, Jun 17, 2011 at 6:29 AM, Paul Eggert wrote: > On 06/16/11 10:36, Alfred M. Szmidt wrote: >> I'm thinking that maybe should be generated with a double >> inclusion guard > > But the general rule is that must always be included first, no? > So there shouldn't ever be a possibility of inclu

bug#8718: error when using nested conditionals

2011-06-16 Thread Bruno Haible
Hello Ralf, > > === foo.m4 > > > > AC_DEFUN([gl_FOO], > > [ > > if test 7 = 7; then > > use_variant_a=true > > else > > use_variant_a=false > > fi > > AM_CONDITIONAL([USE_VARIANT_A], [$use_variant_a]) > > Instea

bug#8881: config.h double inclusion

2011-06-16 Thread Paul Eggert
On 06/16/11 10:36, Alfred M. Szmidt wrote: > I'm thinking that maybe should be generated with a double > inclusion guard But the general rule is that must always be included first, no? So there shouldn't ever be a possibility of including it twice. It might be better to have config.h do somethi

bug#8718: error when using nested conditionals

2011-06-16 Thread Ralf Wildenhues
Hello, and sorry for the delay, * Bruno Haible wrote on Fri, Jun 10, 2011 at 01:29:57AM CEST: > > Cannot you simply initialize the > > automake conditionals you might need and that you know might be called > > conditionally to (possibly dummy) defaults in gl_INIT or gl_EARLY or > > something like

bug#8881: config.h double inclusion

2011-06-16 Thread Alfred M. Szmidt
Hey, in inetutils we have a problem of where sometimes is included twice, but gnulib redefines a macro that was already specified in , for example gnulib:lib/argp.h: #include -- #define HAVE_DECL_PROGRAM_INVOCATION_NAME 0 #define GNULIB_PROGRAM_INVOCATION_NAME 1 ... #include --

bug#7647: [PATCH] {maint} Warnings about primary/prefix mismatch fixed and extended.

2011-06-16 Thread Stefano Lattarini
The patch has been finally as commit v1.11-373-g9ca6326, with a non-trivial optimization (for speed reasons) to a test case applied with follow-up commit `v1.11-374-ged078da'. I'm thus marking this bug as closed. Regards, Stefano