bug#11745: the new test-suite summary is confusing

[Jim Meyering]

On Mon, Jun 1, 2020 at 6:46 PM Karl Berry  wrote:
> Hi Alexandre and all - regarding
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=11745 (12 years ago, oh well).
>
> I upgraded to Automake 1.12.1 to discover the each of these test-suite
> [directories] now displays a huge summary like:
> 
> 
> Testsuite summary for spot 0.9.1a
> ...
> The above in definitely *not* a testsuite summary for
> the project, it's only a test summary for one directory.
>
> Agreed, but:
>
> I think the easiest fix would be to change the header to just
> "Testsuite summary", without mentioning the package.
>
> I don't think that's the right fix. In TeX Live, we have many different
> packages, all in one Automake tree, and if every testsuite summary just
> said "TeX Live", it would be difficult to discern what the summary was
> reporting on. That is, the TL make check output starts like this:
> Testsuite summary for Kpathsea 6.3.3/dev
> ..
> Testsuite summary for zlib (TeX Live) 1.2.11
> ..
> Testsuite summary for lua53 (TeX Live) 5.3.5
>
> If all of those just said "TeX Live", it wouldn't be good.
>
>
> I don't think we should change the default form of the Automake header
> line at this late date, since some packages (and plenty of AM's own
> tests) might well be expecting what's currently output.
>
> So I propose to define a new variable in lib/am/check.am:
> AM_TESTSUITE_SUMMARY_HEADER = " for $(PACKAGE_STRING)"
> so the default is unchanged.

Thanks, Karl!
This looks great. Only one minor suggestion: to use single quotes
there, rather than double:

  AM_TESTSUITE_SUMMARY_HEADER = ' for $(PACKAGE_STRING)'

so that the replacement value is less likely to require additional escaping.

bug#41726: vala-mitx2 test fails with gcc10

[Andreas Radke]

Building automake 1.16.2/autoconf 2.69 I'm seeing this test failure
here compiling using gcc 10.1.0 for Arch Linux:

This is due to gcc 10 defaults to -fno-common now. See
https://gcc.gnu.org/gcc-10/changes.html

To pass that test one can export CFLAGS="$CFLAGS -fcommon". Test also passes
using clang 10.0.0

FAIL: /vala-mitx2
=

vala-mix2: running valac --version
Vala 0.48.6
vala-mix2: running pkg-config --version
1.7.3
vala-mix2: determine whether make is GNU make
GNU Make 4.3
License GPLv3+: GNU GPL version 3 or later 
pkg-config version: 1.7.3
# pkg.m4 - Macros to locate and utilise pkg-config.   -*- Autoconf -*-
# serial 11 (pkg-config-0.29.1)

dnl Copyright © 2004 Scott James Remnant .
dnl Copyright © 2012-2015 Dan Nicholson 
dnl
dnl This program is free software; you can redistribute it and/or modify
dnl it under the terms of the GNU General Public License as published by
dnl the Free Software Foundation; either version 2 of the License, or
dnl (at your option) any later version.
dnl
dnl This program is distributed in the hope that it will be useful, but
dnl WITHOUT ANY WARRANTY; without even the implied warranty of
dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
dnl General Public License for more details.
dnl
dnl You should have received a copy of the GNU General Public License
dnl along with this program; if not, write to the Free Software
dnl Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
dnl 02111-1307, USA.
Running from installcheck: no
Test Protocol: none
PATH = 
/build/automake/src/automake-1.16.2/bin:/build/automake/src/automake-1.16.2/t/ax:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
++ pwd
/build/automake/src/automake-1.16.2/t/vala-mix2.dir
+ cat
+ cat
+ cat
+ cat
+ cat
+ cat
+ cat
+ cat
+ aclocal-1.16 -Werror
+ automake-1.16 --foreign -Werror -Wall -a
+ autoconf
+ ./configure --enable-dependency-tracking
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking whether cc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of cc... gcc3
checking whether we are using the GNU C++ compiler... yes
checking whether c++ accepts -g... yes
checking dependency style of c++... gcc3
checking for valac... /usr/bin/valac
checking whether /usr/bin/valac is at least version 0.7.3... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GOBJECT... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: executing depfiles commands
+ make all
rm -f zardoz_vala.stamp && echo stamp > zardoz_vala.stamp-t
CDPATH="${ZSH_VERSION+.}:" && cd . && /usr/bin/valac   -C zardoz.vala
mv -f zardoz_vala.stamp-t zardoz_vala.stamp
cc -DPACKAGE_NAME=\"vala-mix2\" -DPACKAGE_TARNAME=\"vala-mix2\" 
-DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"vala-mix2\ 1.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"vala-mix2\" 
-DVERSION=\"1.0\" -I.   -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt 
-MT zardoz.o -MD -MP -MF .deps/zardoz.Tpo -c -o zardoz.o zardoz.c
mv -f .deps/zardoz.Tpo .deps/zardoz.Po
cc -DPACKAGE_NAME=\"vala-mix2\" -DPACKAGE_TARNAME=\"vala-mix2\" 
-DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"vala-mix2\ 1.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"vala-mix2\" 
-DVERSION=\"1.0\" -I.   -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt 
-MT bar.o -MD -MP -MF .deps/bar.Tpo -c -o bar.o bar.c
mv -f .deps/bar.Tpo .deps/bar.Po
cc -DPACKAGE_NAME=\"vala-mix2\" -DPACKAGE_TARNAME=\"vala-mix2\" 
-DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"vala-mix2\ 1.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"vala-mix2\" 
-DVERSION=\"1.0\" -I.   -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include  -march=x86-64 -mtune=generic -O2 -pipe -fno-plt 
-MT baz.o -MD -MP -MF .deps/baz.Tpo -c -o baz.o