Re: Interested in contributing to Bash

2017-05-23 Thread Chet Ramey
On 5/23/17 2:55 PM, John McKown wrote: > > > On Tue, May 23, 2017 at 1:39 PM, Chet Ramey > wrote: > > > The best thing to read to learn about how the shell is structured -- other > than the code itself -- is the unedited version of the

Re: Interested in contributing to Bash

2017-05-23 Thread John McKown
On Tue, May 23, 2017 at 1:55 PM, John McKown wrote: > > > On Tue, May 23, 2017 at 1:39 PM, Chet Ramey wrote: > >> >> The best thing to read to learn about how the shell is structured -- other >> than the code itself -- is the unedited version

Re: Interested in contributing to Bash

2017-05-23 Thread John McKown
On Tue, May 23, 2017 at 1:39 PM, Chet Ramey wrote: > > The best thing to read to learn about how the shell is structured -- other > than the code itself -- is the unedited version of the chapter I wrote for > AOSA (The Architecture of Open Source Applications). It's in the

Re: Interested in contributing to Bash

2017-05-23 Thread Chet Ramey
On 5/23/17 2:49 PM, Pranav Deshpande wrote: > Thank you! > I will be reading it now. What do you think of the 'bugs' Eduardo mentioned? I'll weigh in later. I'm still catching up from traveling. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita

Re: Interested in contributing to Bash

2017-05-23 Thread Pranav Deshpande
Thank you! I will be reading it now. What do you think of the 'bugs' Eduardo mentioned? Regards, Pranav. On Wed, May 24, 2017 at 12:09 AM, Chet Ramey wrote: > On 5/21/17 11:53 AM, Eduardo Bustamante wrote: > > On Sun, May 21, 2017 at 5:44 AM, Pranav Deshpande > >

Re: Interested in contributing to Bash

2017-05-23 Thread Chet Ramey
On 5/21/17 11:53 AM, Eduardo Bustamante wrote: > On Sun, May 21, 2017 at 5:44 AM, Pranav Deshpande > wrote: > [...] >> Any guidance on so as how to get started? Are there any tasks that I can >> take up so that I get introduced to the code base. > > My

Builtin read with -n0 or -N0 (nchars == 0) behaves as a read with no -n/-N argument

2017-05-23 Thread Eduardo Bustamante
(I think this is a good problem for Pranav to tackle if you consider this to be a bug, Chet). Current behavior: dualbus@debian:~$ bash -c 'read -n0 <<< "abc"; declare -p REPLY' declare -- REPLY="abc" dualbus@debian:~$ bash --version|head -n1 GNU bash, version 4.4.11(1)-release

Builtin history -r does not work with named pipes (i.e. GNU readline's histfile.c read_history_range)

2017-05-23 Thread Eduardo Bustamante
(I think this is a good problem for Pranav to tackle if you consider this to be a bug, Chet). The problem is that fstat(2) will return an st_size of 0 if the file is non-regular. I think that the easiest path here is to goto `error_and_exit' if `file' is not a regular file (and perhaps print a

Re: PWD not made canonical on shell start

2017-05-23 Thread Eduardo Bustamante
On Tue, May 23, 2017 at 8:51 AM, wrote: [...] > Bash Version: 4.3 > Patch Level: 48 > Release Status: release I can reproduce with 4.4.11(1)-release and the latest devel branch [...] > As implemented, I now have to start every shell script that > uses

PWD not made canonical on shell start

2017-05-23 Thread idallen
Configuration Information [Automatically generated, do not change]: Machine: x86_64 OS: linux-gnu Compiler: gcc Compilation CFLAGS: -DPROGRAM='bash' -DCONF_HOSTTYPE='x86_64' -DCONF_OSTYPE='linux-gnu' -DCONF_MACHTYPE='x86_64-pc-linux-gnu' -DCONF_VENDOR='pc' -DLOCALEDIR='/usr/share/locale'