Potential buffer under-run in shell_execve()

2016-08-15 Thread John E. Malmberg
Hello, In Bash 4.3.42: In execute_cmd/shell_execve(), if HAVE_BASH_BANG_EXEC is defined, the macro READ_SAMPLE_BUF has the potential to set sample_len to -1. #if defined (HAVE_HASH_BANG_EXEC) READ_SAMPLE_BUF (command, sample, sample_len); sample[sample_len - 1] = '\0';

Re: Source Code Bug in Bash-4.3.31 Module variables.c

2015-07-04 Thread John E. Malmberg
On 3/7/2015 10:59 AM, Eric Robertson wrote: snip In any case, the abort message from the OpenVMS C compiler was as follows: CC/name=(as_i,shor)/repo=lcl_root:[bash.cxx_repository]/debu/list/mach/show=(EXPA,INC)/prefix=(all,exce=(strtoimax,strtoumax))/neste

Re: y.tab.c inclusion within the source tree

2014-09-28 Thread John E. Malmberg
On 9/27/2014 6:49 PM, Mark Goldfinch wrote: Hi everyone, Can someone clarify to me why y.tab.c is included within the bash source tree if it is generated from parse.y? Not all platforms have up to date tools for generating y.tab.c from parse.y. snip Seeing that it appears likely we're going

Bash 4.2.45 now available for VMS at GNV site.

2013-07-29 Thread John E. Malmberg
The GNV team is pleased to announce that BASH 4.2.45 is now available for OpenVMS at the GNV site. GNV is the GNU on VMS project. Thanks to extensive work by Eric Robertson and feedback from testers of the previous Bash 4.2.39 port, this is the most accurate and functional port of Bash to VMS

Re: Bash 4.2.39 now available for OpenVMS Alpha/I64

2012-12-20 Thread John E. Malmberg
On 12/20/2012 9:36 AM, Chet Ramey wrote: On 12/16/12 10:51 AM, John E. Malmberg wrote: For those that want to look at the source, you can examine or check out the OpenVMS specific changes in the http://gnv.cvs.sourceforge.net/gnv/ cvs tree from the gnu_vms/bash tree with the cvs tag gnv-bash

Bash 4.2.39 now available for OpenVMS Alpha/I64

2012-12-16 Thread John E. Malmberg
Bash 4.2.39 is now available for OpenVMS. Pre-built PCSI kits are at: ftp://encompasserve.org/gnv/axp0830/ Alpha 8.3 kits ftp://encompasserve.org/gnv/axp0840/ Alpha 8.4 kits ftp://encompasserve.org/gnv/i640840/ Itanium 8.4 kits The kits include the source code and build procedures.

savestring() macro in general.h runs function arguments twice.

2012-11-23 Thread John E. Malmberg
The execute_cmd.c module uses make_command_string() as a parameter to the savestring() macro. This causes the savestring() macro to call that function twice(). I have not done any timing tests to see how this is impacting performance, but it definitely shows up when stepping through commands

Re: cygwin: glob successfully for executables without .exe suffix

2012-09-09 Thread John E. Malmberg
On 9/9/2012 7:52 PM, Gregory M. Turner wrote: The enclosed patch fixes (or tries to fix) the inability to glob for executable files on cygwin without the .exe suffix. This is required because cygwin has a hack to behave as though foo and foo.exe both exist as hardlinks to the same file, but

sys/param.h not checked for by configure

2012-07-29 Thread John E. Malmberg
Hello all, The header file sys/param.h is not checked for by configure and is not provided by the VMS environment. I have worked around this issue by having the VMS specific build script create an empty substitute file. The HP VMS Engineering team has indicated a willingness to add the

Bug in patch bash42-018, leaves lastpipe_flag unitialized for platforms with out JOB_CONTROL.

2012-06-21 Thread John E. Malmberg
Hello Bash-bugs, The patch bash42-018 to allow execute_cmd.c that is supposed to allow it to compile with out JOB_CONTROL defined has a bug in it. It is leaving the lastpipe_flag uninitialized. This is a problem because later in the module it is tested. ***

VMS port - Advice wanted for not having a fork() call.

2012-06-06 Thread John E. Malmberg
The existing port of Bash for VMS claims to be 1.4.8, which as near as I can tell must be based on 1.4.7, as I do not see a 1.4.8 in the download section. What they did to work around that VMS does not have a fork() call, is to: Make a copy of several global variables and structures.

Re: lib/sh/mktime.c VMS specific code is not needed.

2012-06-04 Thread John E. Malmberg
On 6/4/2012 8:05 AM, Chet Ramey wrote: On 6/2/12 7:51 PM, John Malmberg wrote: The lib/sh/mktime.c module has a VMS specific include ofsys/types.h to pick up time_t. No, it doesn't. VMS systems includestddef.h. I see I read it wrong. On VMS, the time_t type is defined in thetime.h

Re: Red-Hat Bug 825751 - bash-completion fails on environment variables

2012-05-29 Thread John E. Malmberg
On 5/29/2012 7:12 AM, Chet Ramey wrote: On 5/28/12 11:32 AM, John E. Malmberg wrote: https://bugzilla.redhat.com/show_bug.cgi?id=825751 bash-4.2.24-1.fc16.i686 Please take a look at http://git.savannah.gnu.org/cgit/bash.git/log/?h=direxpand and see if that behaves the way you like. Thanks

Red-Hat Bug 825751 - bash-completion fails on environment variables

2012-05-28 Thread John E. Malmberg
https://bugzilla.redhat.com/show_bug.cgi?id=825751 bash-4.2.24-1.fc16.i686 Steps to Reproduce: 1. Activate a terminal running a bash shell 2. ls $HOME/TAB 3. Actual results: ls \$HOME/ I get the directory get expanded result on Bash 1.4.8 (VMS special build) and on Bash 3.2.25(1)-release.

obsolete vms specific code in lib/glob/ndir.h

2012-05-12 Thread John E. Malmberg
The lib/glob/ndir.h file has some VMS specific code in it. That header file is not used by VMS in building bash. Even if it where to be used, the code is out of date and would not work on current versions of VMS. I recommend removing the VMS specific code from that file. Regards, -John

Re: [patch] jobs.c not checking HAVE_SYS_PARAM_H

2011-10-13 Thread John E. Malmberg
I posted this to the gmane.comp.shells.bash.bugs newsgroup two days ago, but have not seen any response. Are postings to there by non-subscribers not making to the mailing list? On 10/10/2011 10:44 PM, John E. Malmberg wrote: In the bash 4.2 source: jobs.c is not checking HAVE_SYS_PARAM_H

[patch] jobs.c not checking HAVE_SYS_PARAM_H

2011-10-10 Thread John E. Malmberg
In the bash 4.2 source: jobs.c is not checking HAVE_SYS_PARAM_H. This prevents it from compiling on VMS which does not supply this header. Regards, -John wb8tyw@qsl.network Personal Opinion Only $ diff -ub a/jobs.c b/jobs.c --- a/jobs.c 2011-09-26 22:28:17.0 -0500 +++ b/jobs.c

Updating Bash port on VMS

2011-09-30 Thread John E. Malmberg
Hello, I and others are working on updating the bash port on VMS the current version of Bash. As this port can not depend the pre-existence of Bash or other common tools, I will end up with a number of additional VMS specific files. This includes build scripts and various helper modules,