Re: [PATCH] Fix foreground dead jobs in trap handlers reported like background ones in `jobs'

2022-10-03 Thread Chet Ramey
On 10/2/22 11:04 PM, Koichi Murase wrote: 2022年10月1日(土) 4:30 Chet Ramey : On 7/17/22 11:52 PM, Koichi Murase wrote: the change to print_job appears not to be needed (at least all of your test cases work without it). Maybe it has been fixed in another way, but how about the following test

[PATCH] glob: add shopt globmtimesort to sort globs by mtime

2022-10-03 Thread Evan Gates
--- There is currently no good way to sort files by mtime in the shell. It's possible to do so with an ls that supports -t, but parsing ls is problematic. It's possible using GNU find's printf %T and nul separated lists with sort -z. Neither is a great option. This patch adds the ability to

Re: logic in m4/strtoimax.m4 inverted

2022-10-03 Thread Chet Ramey
On 10/1/22 6:38 AM, Emanuel Haupt wrote: Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64). The logic in m4/strtoimax.m4 is inverted. The following patch replaces strtoimax() if and only if it is present and functional. Thanks for the report. You're right, of course. I

getconf.c breaks --disable-nls

2022-10-03 Thread adamw
Configuration Information [Automatically generated, do not change]: Machine: amd64 OS: freebsd13.1 Compiler: cc Compilation CFLAGS: -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing uname output: FreeBSD apnoea.adamw.org 13.1-RELEASE-p2 FreeBSD

Re: [PATCH] Fix foreground dead jobs in trap handlers reported like background ones in `jobs'

2022-10-03 Thread Chet Ramey
On 10/2/22 11:04 PM, Koichi Murase wrote: 2022年10月1日(土) 4:30 Chet Ramey : On 7/17/22 11:52 PM, Koichi Murase wrote: Thanks for the detailed report and suggested patches. I applied a variant of your patch 3; Thank you for taking the time to review and apply the patch. the change to print_job